search

mspass-team / mspass

Massive Parallel Analysis System for Seismologists
https://mspass.org
BSD 3-Clause "New" or "Revised" License
28 stars 11 forks source link

bug in resample function messes up timing #545

Open pavlis opened 4 weeks ago

pavlis commented 4 weeks ago

After many hours over the last 24 I have established that there is a bug in the resample function. Note also there is something wrong with our configuration as none of the docstrings found in algorithms/resample.py are in the sphnyx docomentation. That is just an annoyance, but the bug is serious. It definitely messes up timing. In the draft Session1 notebook for the upcoming short course I had a line to downsample the data from 40 to 20 sps. I was mystified why I wan't getting QC plots windowed around P that looked right. The reason was the window was always at the wrong time because the resample operator did something I don't quite understand. We are going to have to do some controlled test to figure this out. The resample operator wasn't essential for this class anyway so it is easy to remove it and not cause an issue. It may increase some run times since we will be handling twice as many samples but it should not be a problem.

wangyinz commented 4 weeks ago

oh... that sounds pretty bad. We definitely want to fix it asap.

wangyinz commented 4 weeks ago

I just got the docs added. The python api doc is not automatic. It needs to be added to the index, which I think was overlooked when resample was added.