search

msperl / linux-rpi

Other
22 stars 26 forks source link

Can was broken without option CONFIG_DEBUG_FS #17

Open jencha opened 3 years ago

jencha commented 3 years ago

Branches: 4.14-rpi...mcp25..fd-v.. I disabled option CONFIG_DEBUG_FS in my kernel config. Driver compiled successful. Then I tested with cangen/candump in FD mode. Candump doesn't get messages.

My notices:

  1. Please, add "{}" to the describing DEBUG macroses (file mcp25xxfd_can_debugfs.h)
  2. In the file mcp25xxfd_can.h variable submit_queue_count incremented through DEBUG macros. I think, it is bug's decision. static inline void mcp25xxfd_can_queue_frame(struct mcp25xxfd_can_priv *cpriv, s32 fifo, u16 ts, bool is_rx) { ... MCP25XXFD_DEBUGFS_INCR(cpriv->fifos.submit_queue_count); }