[Intro to iOS] Assignment 1 completed

[mspielberg]

/cc @codepath (Note that the assignment submission instructions still mention @thecodepath in screenshots.)

[dirkdk]

I can't get the app to build

I think you need to use a workspace instead of just a project for use with Cocoapods

[dirkdk]

OK, after I ran Pod Install, a workspace file was created, and I could build the app. I think you should check in the workspace files

One last remark, the keyboard does not disappear after using Search. More people had this problem, ask the teacher what to do

[mspielberg]

I'm still not sure where to draw the line in terms of what to check in. Checking in the complete workspace (including the component files of the various Pods) seemed like it would bloat the repo with code I don't have the rights to redistribute, and including the .xcworkspace directory without including the Pod source code would mean someone checking out the repository would still have to 'pod install' to get something buildable, just as you did.

I did actually have a fix for the search bar yesterday afternoon, which I've pushed, but thought I was probably beyond the submission deadline.

(Edit: grammar)

[dirkdk]

the other students checked in their workspace, makes live easier for me. Maybe ask this to the teacher

I think your deadline was Sunday midnight. Next week, I will start looking at code Monday morning around 9.

keep up the good work!

[codepathreview]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

• see comment above^^
• your project organization is a bit messed up, try to get all code here https://github.com/mspielberg/codepath-rottentomatoes/tree/master/RottenTomatoes
• Be sure to follow the Objective-C code styling conventions for the homework. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
• Nice work with the header files. You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. It might be interesting to check out the Mantle project for a lightweight ORM.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Nice work loading the images asynchronously.
• Nice work setting up the proper modes for the images so that they are not stretched.
• Nice work implementing the error message on network failure.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

--dirk

[mspielberg]

• see comment above^^

Talked with Tim in class, and I'll be checking in full workspaces for future assignments. Sorry for the trouble!

• your project organization is a bit messed up, try to get all code here https://github.com/mspielberg/codepath-rottentomatoes/tree/master/RottenTomatoes

Thanks for the feedback. Xcode's group organization within the IDE makes it easy to miss that the actual filesystem layout is getting wonky.

• Be sure to follow the Objective-C code styling conventions for the homework. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.

I'll take another pass through the NYT coding standards. Were there any particular facets or anti-patterns in this project I should be looking out for in the future?

• Nice work with the header files. You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).

Were there instances of this other than the MovieCell discussed below you had in mind in particular? Or is this more under the category of general advice for the future?

• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. It might be interesting to check out the Mantle project for a lightweight ORM.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.

Currently looking at implementing this model for the next assignment.

Thanks for the detailed feedback!

[codepathreview]

1. Re header files, that is a general comment. Its about separation of concerns, what you expose and what you keep internally
2. try moving the responsibility from laying out the movie cell to the actual cell, and not the controller. The controller should just move around data, and not become fat.

example:

@implementation MovieTableViewCell
..

- (void) setMovie:(MovieModel*)movie {
  [self..posterView  setImageWithURLRequest: movie.url];
  self.titleLabel.text = movie.title;
}
@end

and then

-(UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath  {
..
[cell setMovie:movieModel];
}