search

mspielberg / dv-remote-dispatch

Derail Valley mod for presenting an interactive web map of the world.
MIT License
19 stars 16 forks source link

Persistent jobs support #17

Closed lassombra closed 5 months ago

lassombra commented 8 months ago

This pull request does two things.

First it resolves #15 allowing persistent jobs to properly update remote dispatch.

Second (and I'm happy to remove this if not desired) it adds a powershell script and instructions for using it to make installation into the mods folder automatic on build allowing for quick and easy testing of changes.

Note - I used reflection to implement the persistent jobs event handler as I didn't want to create a dependency on persistent jobs. If a different approach is desired, I'm more than happy to do so. I'm also more than happy to relocate or adjust any of this code.

lassombra commented 6 months ago

I'll try to make the requested changes this weekend.

As for the package.ps1 and the contributing section, I'll just remove those at this point - since you use a different packaging system it doesn't make sense to double down.

I'll re-request review once I've made the appropriate changes