search

mspraggs / potentia

Southampton Game Jam 2015
0 stars 0 forks source link

Refactor Block::update #56

Closed mspraggs closed 9 years ago

mspraggs commented 9 years ago

There's several statements in this function that are a bit confusing at first glance and could perhaps be streamlined or abstracted away. I've added some comments to explain in more detail.

Addresses #6

Fyll commented 9 years ago

I've split it up a lot better, but am not happy that what I did was exactly what you were requesting. Could you pull and see?

mspraggs commented 9 years ago

That looks really good! To be honest I wasn't quite sure how it could be cleared up, but what you've done looks great! I've added a line to compute the norm vector pointing from *this to obj, just because it's used twice, but this is a minor change.