msr-consulting / exscalabar

User interface for the EXSCALABAR instrument.
http://www.msrconsults.com/ukmet-gh/exscalabar
1 stars 2 forks source link

condense CRDS laser controls #113

Closed JustinLangridge closed 7 years ago

JustinLangridge commented 8 years ago

Only one frequency and duty cycle controlneeded to serve all lasers now.

JustinLangridge commented 7 years ago

Given the potential for messing up the crds acquisiton timing when using these contols, this would be good to address during phase 3

lo-co commented 7 years ago

I am not following how this messes up anything. Entering something in one box changes all, right? So, what is the difference between having one or all? The idea behind having the UI elements is for future spec'ing.

lo-co commented 7 years ago

So, I took a look at this and it looks like in the cvt-service::Crd::setLaserRate someone (Dave presumably) has eliminated the case structure. The function now looks like

this.setLaserRate = function (index, f) {

    var cmd = 'CRDS_CMD/fblue?Rate=' + f;
    this.fblue = f;
    http.get(net.address() + cmd);
     //if (index) {
    cmd = 'CRDS_CMD/fred?Rate=' + f;
    this.fred = f;
    //} else {
    this.fblue = f;
    //}

    http.get(net.address() + cmd);
};

What will happen now is that the only command that will be sent is to change the rate on the red laser; is this intentional? Do you still want me to "condense" these controls to a single set of duty cycle, rate, gain and enable? Or how do you want them condensed?

lo-co commented 7 years ago

This is good to go.