Complete Calibration page

msr-consulting / exscalabar

User interface for the EXSCALABAR instrument.

http://www.msrconsults.com/ukmet-gh/exscalabar

1 stars 2 forks source link

Complete Calibration page #125

Open lo-co opened 7 years ago

lo-co commented 7 years ago

Much of the functionality is here, but we need to:

Pass on what calibration we are doing (two types are pressure and ozone)
Persistent indication of current calibration
Indication of where we are in the calibration (requires server changes)
Allow user to start calibrations from the page
Drop down box providing selection of files available
Ability to copy and rename files

lo-co commented 7 years ago

So, with the most recent check in we have:

ability to remove steps
popup dialog indicating to the user that they have not saved the most current version of the calibration
autopopulation of calibration with default calibration

cathrynjfox commented 7 years ago

Tried running this today (19th Dec). Problems include:

The settings for the flows on the O3 and O2 flow controllers don't seem to work
Not sure that setting the ozone lamp frequency (or % as is currently labelled) actually does anything
After clicking 'start cal' the labview block diagram pops up flashing - after clicking continue a few times it then runs.
After running the cal for about 2 minutes, everything (lasers, pump, TECs) suddenly turns off for no discernible reason.

lo-co commented 7 years ago

This comment is on the wrong page - you don't have the most recent version of the server. We need to pull that. Sorry about the confusion.

JustinLangridge commented 7 years ago

This is generally working. Need to look at changing some of the labels (e.g. O3 lamp is a frequency not %). Will the added functionality indicated in the initial issue (e.g. for file selection) still be implemented?

lo-co commented 7 years ago

Changed O3 lamp to frequency in steps (found in ex.calibration.ctl.js).

I will add a drop down - this will take a little more work (one extra step I believe and some server-side changes).

lo-co commented 7 years ago

Added a dropdown that provides two options - ozone and pressure; ozone is default. The page before this change showed what would be displayed if ozone is selected. If pressure is selected, the selections are essentially truncated such that there are no ozone related steps.

Remaining TODO:

Provide two calibration files on server side - one for pressure and one for ozone.
Allow for selection on server side for saving and running purposes.
Make sure that when the selection is changed, the correct file is retrieved with the steps pertaining to that cal in the right hand box on the UI.

lo-co commented 7 years ago

Associated with commit 6389105.