search

msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

Init Power turns on wrong breakers #112

Closed lo-co closed 8 years ago

lo-co commented 8 years ago

The order of the digital outputs in Init Power.vi different to MAX.

lo-co commented 8 years ago

Need a little more information than this. Are they reversed or are they just jumbled? How do you know they are incorrect? Indicators or actual physical testing?

This actually sounds like a UI issue given that both instances use the exact same task to run the DO. My tests actually suggested that all was well with this but I will double check that the logic on the UI is correct (uses a U8 to broadcast the collect power state to the server and vice versa).

lo-co commented 8 years ago

So, I just read the commit message for the above reference and it sounds like the order things were coming on were wrong. Is this correct? Did the push above fix this? Can you close this if it did?

lo-co commented 8 years ago

And, looking at Init Power, this looks really wrong! If you were having an issue, I am concerned that the issue may be in the message PowerSupply MSG. Checking this. If this message is screwed up, the impact would be that the power would init ok, but attempts to change things would be broken.

lo-co commented 8 years ago

Dave, we need to talk about this. The array in Init Power is totally jumbled now. The inputs should be 1) Sample Pump, 2) O3 Generator 3) Denuder, 4) Laser, and 5) TEC. In Init Power, this is 1) Denuder, 2) Laser, 3) O3 Generator 4) Sample Pump and 5) TEC. I tested this prior to the update above and the inputs and outputs are as I expect, so it is unclear

  1. how the new Init Power gets it right
  2. why it gets it right
  3. why you would be able to get the right response from the UI.

I should pull into a position where we can talk about this around 9 am my time. Can you be around?

JustinLangridge commented 8 years ago

This issue is now more generally covered by problems with initialization (ref #132, #124). Closing here.