Filter and speaker cycling

[JustinLangridge]

Add option to lock speaker auto-cycle to filter auto-cycle and add access to this control via UI

[lo-co]

Added button on Configuration page.

[lo-co]

In the Controller::Handle Filter Automation method, I have added logic that says

if filter_cycle AND speaker_cycle AND filter THEN set speaker

Now need to add this exact same code to the Change Filter State message.

[lo-co]

Added code to the message Change Filter State. The value in the CVT is found under the group pas and is called filter_cycle. This value has a corresponding INI entry called connect_filter under the PAS section.

Now need to add web service for toggling this

[lo-co]

Added read entry to Controller::Initialize CVT. As part of this, I also added the VI Controller::Init PAS CVT to begin to clean things up.

[lo-co]

Added web service PAS/SpkFilterConnect with the input conn. This value is 0 or not zero, with 0 being FALSE and not 0 TRUE. Next step is testing this.

[JustinLangridge]

Tested this today. Issues are:

• the connect filter cycle button doesn't appear to do anything. It can't be activated via the UI
• the filter control on the configuration page similarly doesn't do anything. Setting both per and len has no impact on the filter valves.

More generally can all of these controls be moved together. It would be good to have the filter cycling controls on the right hand panel with the valve controls which are always visible, and the speaker lock button with the speaker cycling controls

Also could we add the definitions of per and len to the controls (some confusion here earlier)

[lo-co]

the connect filter cycle button doesn't appear to do anything. It can't be activated via the UI

Fixed

the filter control on the configuration page similarly doesn't do anything. Setting both per and len has no impact on the filter valves.

Fixed

Also could we add the definitions of per and len to the controls (some confusion here earlier)

Done

It would be good to have the filter cycling controls on the right hand panel with the valve controls which are always visible

This just seems cluttered to me. I left the filter valve control itself on the side panel but the cycling controls on this panel seem like a bad idea. These are controls which you will rarely adjust (if you are adjusting these regularly than we have an operational issue). I will leave these where they are for now. Let's raise another issue later if you absolutely need these there. Might be better to just have the filter countdown there? That way you know that the system is cycling and when.

the speaker lock button with the speaker cycling controls

Going to add a reference now.

[lo-co]

Here is what the filter and speaker cycling together look like in the speaker domain:

[lo-co]

If you feel the UI changes are necessary, please submit a ticket on the UI side...

[JustinLangridge]

OK this works with the harware too - thanks.

The spikes you see in the IA plot above when you turn the speaker off are erroneous - presumably because we start to integrate and plot the IA before the speaker is fully off. Is it an easy fix to put in a 1s delay after speaker switch off to stop these spikes appearing? We can chop these periods during data analysis, but the driver for doing it online is that when we're ambient sampling these spikes will screw up the scaling

[lo-co]

Raise that as a new issue.