search

msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

Valve states #115

Closed JustinLangridge closed 8 years ago

JustinLangridge commented 8 years ago

Update software to yield correct valve positions (i.e. 5V = open or shut?). These are being tested currently and will be provided when available

lo-co commented 8 years ago

Can you all let me know ASAP what is going on with your tests? This is an easy fix, but I need to know the proper valve states.

JustinLangridge commented 8 years ago

Right Matt, here is the logic for the three pairs of Hanbays:

Format: 'name of position', valve 1 drive value, valve 2 drive value

Denuder: denuder 1 - 5V, denuder 2 - 0V Denuder bypass: denuder 1 - 0V , denuder 2 - 5V

Filtering: filter 1 - 5V, filter 2 - 5V (not a typo they should both be 5V) Sampling: filter 1 - 0V , filter 2 - 0V

Cabin inlet: cabin 1 - 0V , cabin 2 - 0V Aircraft inlet: cabin 1 - 5V, cabin 2 - 5V

JustinLangridge commented 8 years ago

Have tested this today. Almost there but remaining issues::

Filter control button: works fine with correct logic

Denuder control: both denuder 1 and 2 get 5V currently when button is pushed. We need the logic to be that shown above

Cabin control button: UI button does't do anything currently (and immediately turns itself off when you push it). Have verified that correct voltages come out when run in MAX

lo-co commented 8 years ago

Denuder

This should be fixed now. The logic in the previous setting was when the button was set to TRUE, the logic provided for the DIO was [T,T]. No will be [T,F] as described above.

Cabin

So, the problem is not on the UI side (thankfully). Command is being sent, the logic is just doing nothing as when the button was set it set the output on the DIO lines to [T,F]; now it will be [T,T]. Also, fixed the output message for the UI and logs so that the output will say [ctl] Set sample path to [val]. where [val] is cabin if the output from the UI is FALSE and inlet if the output is TRUE.

JustinLangridge commented 8 years ago

Matt, we've had the main electronics box out today. Rob has fixed issues with the CRD pulse signal not getting through and reversed polarity on a set of PMT gain outputs. We'll have it back in tomorrow and will test the valve states fix then

JustinLangridge commented 8 years ago

Looks good now for all three valve pairs now, thanks