search

msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

CRD initialization not accounting for INI file #124

Closed lo-co closed 7 years ago

lo-co commented 8 years ago

This is a hot mess and needs to be consistent with PAS. Basically, we update the CVT in the Controller and then in the launch of the Instrument actor, we push those values into the respective instrument using Command object. We are not doing this for the CRD.

lo-co commented 8 years ago

Added two commands:

These along with the command to change the enable are now fired in eCRD::Configure.

lo-co commented 8 years ago

Still need to add in the laser initialization stuff properly. Push this into where we set up the IO for the different lasers.

lo-co commented 8 years ago

Noted an initialization problem that was logged with the UI. Red laser was initialized for 1 kHz but coming out at 1.3 kHz? Don't know what the problem is here...

JustinLangridge commented 8 years ago

Matt, note this isn't restricted to the CRDS. For example the PAS is not initializing with all lasers enabled (as specified n the ini file) and the speaker voltages don't initialize to the correct values either. Seems we have a generic issue with the initialization?

JustinLangridge commented 8 years ago

ok so a lot of the PAS initialization is ok now, but CRD lasers are still not initializing correctly. UI controls are updating as per the ini file (e.g. as we change frequency) but the actual laser settings are not.

This is only an initialisation problem and controls are working ok otherwise

JustinLangridge commented 7 years ago

Looks like we still have a problem here. Fore example, CRDS laser enables are currently set in the ini to FALSE, but the system initialises with lasers on

JustinLangridge commented 7 years ago

Matt has this been addressed and is it really ready for testing. I think we still have problems here

lo-co commented 7 years ago

Did you check it? I would have probably checked it before removing the tag. I will look into it.

lo-co commented 7 years ago

OK...so this does what it is supposed to do from the code standpoint. When eCRDS::Configure is called, the Laser Enable CMD object is shipped. I can see that the values are read correctly from the configuration file (all TRUE).
Can you please check this again?

JustinLangridge commented 7 years ago

Ok the CRDS side of this is working . Closing this issue. If we come across similar instances in the future will raise them as separate issues