search

msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

Invert DIO for laser enable signals #125

Closed lo-co closed 8 years ago

lo-co commented 8 years ago

Laser enable signals should be pulled low for running lasers - 0 V = enabled and 5 V = disabled.

This issue was originally raised in lo-co/exscalabar#87.

lo-co commented 8 years ago

Changed PAS enable signal in Change Laser Enable State::Handle Command in ePAS Library so that the logic sent to the FPGA is inverted. Logic associated with the CVT and the message is the same.

Cleaned up the message in Set Las Enable MSG::Do so that the CVT is updated when the command is successful. Removed the CVT update from the ePAS command handler.

lo-co commented 8 years ago

Have now fixed the inversion on both the CRDS and the PAS signals. This part is ready for testing. Not sure if the CRD routing portion is fixed, but have opened a new issue associated with this in #126.

JustinLangridge commented 8 years ago

Almost working fix needed is now described in #126. Closing.