search

msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

Attempt to read device repeatedly fails #127

Open lo-co opened 8 years ago

lo-co commented 8 years ago

Vaisala is very apparently not there yet somehow made it out of configuration. Need to fix this such that

  1. If device dies, it will be removed after a certain number of tries, or the user has the opportunity to remove it
  2. Device does not get past configuration if it does not respond to initial read commands,

image

lo-co commented 8 years ago

Likely the only way to handle 1 is to have a device failure count. This would be a count maintained by the class (a DVR) that would increment a count every time an attempt to communicate with the device failed. If successful communication resumes, the count would be reset. If the count reaches a maximum number, output a log message and either

  1. remove the device instance from the global list, or
  2. suspend communication with device until count reset externally
JustinLangridge commented 7 years ago

Agreed this is future work. We may want to look at changing behaviour of initialisation a bit (so that probes are not permanently given up on), but this would be something to look at in the future