search

msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

Denuder switch logic needs changing #129

Closed JustinLangridge closed 8 years ago

JustinLangridge commented 8 years ago

The labelling on the denuder valve UI control is not consistent with that on the LED display board which is confusing.

Please can we make the following changes to address this:

1) Change name of UI control from Denuder to Denduer bypass

2) Reverse logic on this control such that when Denuder bypass is enabled it send the voltages that are currently sent when the control is disabled (and vice versa)

3) Note that the logic for the Denuder LED does not need changing

lo-co commented 8 years ago

(1) is client side - this is done.

(2) Not sure if I am totally following this, but I am reversing the voltages on the server side that are sent to the valve, but not what we store in the CVT. This means that when the user presses the button, we will send a true to the server and the value sent to the valve will now be [false, true] rather than the current [true, false]. Is this incorrect? Try it out...

JustinLangridge commented 8 years ago

All looks good with logic for both valve position and indicator LEDs. Closing