msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

pressure controller not initilising #152

Closed JustinLangridge closed 8 years ago

JustinLangridge commented 8 years ago

pressure controller is not initialising from the ini file correctly. It defaults to 0mb!

This may be because we are using the wrong command in the ini file? C ommand we've inserted is:

prCntl.p0 = 1100.00

lo-co commented 8 years ago

Yes - that is wrong. Use the following to set it:

prCntl.Q0 = 1100

I have changed this in the INI file. Please check this again.

lo-co commented 8 years ago

Hey guys, can one of you tell me if the units are millibars on the controller? Looks like they are to me.

lo-co commented 8 years ago

Never mind - looks like they are.

lo-co commented 8 years ago

This looks like this is working now. Fixed the setpoint display issue there on the right hand side. Changed the code in ExFlowSvc:

function getData() {

            // Store the ID as key
            var key = "";

            for ( var i = 0; i < alicats.length; i++) {
                // Check to see if the current ID is in the Data Object
                if (alicats[i].id in Data.data) {

                    key = alicats[i].id;

                    if (!(key in flow.data)) {
                        flow.data[key] = new fData();
                        if (flow.IDs.length === 0) {
                            flow.IDs = [key];
                        } else {
                            flow.IDs.push(key);
                        }

                        // Check to see if this is a controller
                        if (Data.data[key].Type.search("C") >= 0) {
                            flow.data[key].isController = true;
                            flow.data[key].Qsp = Data.data[key].Qsp;
                        }
                    }

                    flow.data[key].P = Data.data[key].P;
                    flow.data[key].T = Data.data[key].T;
                    flow.data[key].Q = Data.data[key].Q;
                    flow.data[key].label = alicats[i].label;
                    flow.data[key].Qsp = alicats[i].sp;

                }
            }

Added the last line about the setpoint.

lo-co commented 8 years ago

Should have been closed with the checkin above but language in the checkin was in correct.