Closed JustinLangridge closed 7 years ago
These are INI values that can be changed by the user:
- Data labelled as 'crds_660' should be 'crds_gas'
- Data labelled as 'crds_gas' should be 'crds_medRH'1
- Data labelled as 'crds_medRH' should be 'crds_660'
- Can we change the name of all variables to avoid explicit reference to wavelength. Instead use 'red', 'blue' and 'green'.
Change Qsp
to SP
.
A couple of extra variable name changes:
Dave - I added you as an assignee. Can you handle this and let me know what issues you are having with trying to close this out. Would be nice to see this one gone ASAP (should be manageable).
I have changed cabin to inlet in the data file, but it is still named cabin through much of the code. I am waiting on more confirmation which position the denuder valve is in before changing that.
Denuder Bypass - should be just that ( the denuder is bypassed ). Labels changed from wavelengths to colours in .ini for PAS and CRDS.
Q0 changed to SP in flow/pressure controller .ini . Qsp changed to SP in file.
Not sure on what to do about etau or tau averages. Otherwise worth checking a file to see if it has the right stuff in ...
etau
is an error parameter from calculating tau based on the LRS paper. You have to specify that you are going to turn it on in order to get something meaningful out of it.
I will take a look at the tau averages today.
Was this ever tested?
Some things in the data file may be changed at a later date, but in terms of this issue I'm happy to close.
Here are the current issues with the data file:
Data labelled as 'crds_660' should be 'crds_gas'
Data labelled as 'crds_gas' should be 'crds_medRH'
Data labelled as 'crds_medRH' should be 'crds_660'
Can we change the name of all variables to avoid explicit reference to wavelength. Instead use 'red', 'blue' and 'green'.
'_ext' and '_extcorr' in the data files would more usefully be in Mm-1. Can we multiply by 10^-8 to make this so.
For all the CRD cells, there are two variables for each cell labelled as .T (e.g. crds_405.T). One has a temperature in it which isn't the same as the vaisala temperature and the other one has zeros in it. Where are these numbers coming from and why are there two variables?
All tau averages are zero (crd_av_5, crd_av_10 etc). Are they being calculated currently? They should be for operation both on and off filter
Pressure controller has associated variables P, T, Q, Qsp, Q0. We only use variables P and Qsp. Can the label for Qsp be changed to Psp?
Change names of variables 'cabin' to 'Inlet' and 'DenudedBypass' to 'Denuder'
crd_RH variable currently all zero
what is etau? Why is it NaN when we run on filter?