msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

Data file #163

Closed JustinLangridge closed 7 years ago

JustinLangridge commented 7 years ago

Here are the current issues with the data file:

lo-co commented 7 years ago

These are INI values that can be changed by the user:

  • Data labelled as 'crds_660' should be 'crds_gas'
  • Data labelled as 'crds_gas' should be 'crds_medRH'1
  • Data labelled as 'crds_medRH' should be 'crds_660'
  • Can we change the name of all variables to avoid explicit reference to wavelength. Instead use 'red', 'blue' and 'green'.
lo-co commented 7 years ago

Change Qsp to SP.

JustinLangridge commented 7 years ago

A couple of extra variable name changes:

lo-co commented 7 years ago

Dave - I added you as an assignee. Can you handle this and let me know what issues you are having with trying to close this out. Would be nice to see this one gone ASAP (should be manageable).

datid commented 7 years ago

I have changed cabin to inlet in the data file, but it is still named cabin through much of the code. I am waiting on more confirmation which position the denuder valve is in before changing that.

datid commented 7 years ago

Denuder Bypass - should be just that ( the denuder is bypassed ). Labels changed from wavelengths to colours in .ini for PAS and CRDS.
Q0 changed to SP in flow/pressure controller .ini . Qsp changed to SP in file.

Not sure on what to do about etau or tau averages. Otherwise worth checking a file to see if it has the right stuff in ...

lo-co commented 7 years ago

etau is an error parameter from calculating tau based on the LRS paper. You have to specify that you are going to turn it on in order to get something meaningful out of it. I will take a look at the tau averages today.

lo-co commented 7 years ago

Was this ever tested?

JustinLangridge commented 7 years ago

Some things in the data file may be changed at a later date, but in terms of this issue I'm happy to close.