search

msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

speaker and filter cycle locking #169

Closed JustinLangridge closed 7 years ago

JustinLangridge commented 7 years ago

Both the speaker and filter cycles work when used on their own.

I can't tell if the connect cycles function is doing what is should be as I am not sure what it is supposed to be doing. Please could you explain.

What I'd like is for it to allow us to have the speaker trigger for a set length of time every time the filter changes position. It isn't doing this currently.

This then raises questions about which controls are used when we lock the cycles - presumably the 'per(s)' control on the speaker becomes redundant?

lo-co commented 7 years ago

As explained in #167, I assume that when you have the speaker on manual (i.e. not automatically cycling by itself), then the user wants explicit control over the speaker position. So, in order to link the two, you will need to set the speaker to cycle and hit the connect button for both. The per (s) is only redundant if

  1. the filter cycle is active AND
  2. the filter cycle per (s) is shorter than the speaker per (s)

The filter cycle does not have to be active in order for you to connect the two - just the speaker cycle.

JustinLangridge commented 7 years ago

Just to confirm the tests performed so far to evaluate performance of the cycle linking have had the speaker set to auto cycling, the filter set to auto cycling and the connect button active. Thus I think we still have a problem here.

The functionality that we need is to have the ability to trigger the speaker for a set length of time every time the filter changes position. Can we implement the connect cycles functionality to work in this way

lo-co commented 7 years ago

This works - have confirmed it multiple times now and am unable to reproduce this behavior under the conditions that you have above. I will try to produce a screen grab that demonstrates what I am seeing.

lo-co commented 7 years ago

OK...so it is easy to reproduce the functionality described.

  1. Set the speaker to autocycle (under PAS select the LED AUTO)
  2. Connect the two cycles (select Connect Cycles so that the LED is lit on the PAS page).
  3. Deselect the speaker so that it is off (Speaker LED should be off)
  4. Cycle the Filter control (turn off - LED not lit - and then on - LED lit).

You should be able to confirm that the Speaker LED lights without user interaction and VIOLA!!! it actually works.

Please let me know if you are still having issues - I suspect that the real problem is not that it doesn't work but rather that I am not doing something that you all expect the system to do. I performed the above test with and without the filter set to autocycle and got the same results. Am getting odd behavior with the speaker autocycling. I will investigate this further.

This functionality is working as expected so the issue is being closed with no action. If you need demonstration of this functionality please let me know before you reopen this issue as this will be the second time the issue has been closed. If you the functionality is not as desired, please open an issue with the tag enhancement and I will work on that enhancement.