search

msr-consulting / exscalabar_server

Repository for the EXSCALABAR server.
http://www.msrconsults.com/ukmet-gh/exscalabar
0 stars 1 forks source link

Remove laser frequency tie to resonant #93

Closed lo-co closed 7 years ago

lo-co commented 8 years ago

Currently, the analysis of the microphone data is always tied to the resonant frequency regardless of the laser frequency. This needs to be changed.

JustinLangridge commented 8 years ago

Note this is linked to issue #100 in server repo

lo-co commented 8 years ago

Not following the comment above. This has to do with the fact that if the user wants to adjust the laser frequency rather than just adjusting to the speaker calibration, then they can do just that. However, the analysis (i.e. IA retrieval) will be based on the frequency returned by the speaker calibration. THIS IS A FUTURE ISSUE.

JustinLangridge commented 8 years ago

Hi Matt, note the reference to #100 is #100 in the UI repo not the server repo.

The basic issue is that if the user changes the laser frequency using these controls, while the laser does change to this frequency, it is then not possible to return to a mode whereby you are using the speaker to determine the frequency (cycling the speaker on and off doesn't change the measures laser output frequency, even thought the UI does update to suggest t should have changed).

Not a problem to leave the other enhancement you mention above to later, but the current behaviour is a problem.

lo-co commented 8 years ago

Ya...I am going to leave it for the future as that it is something that until this year we have not noticed. It needs to change (and will) but we will spec for later.

JustinLangridge commented 8 years ago

That is fine Matt. Just to confirm though, can we still look at #100 on the UI repo as this could cause us problems

lo-co commented 8 years ago

lol. you mean lo-co/exscalabar#100?

lo-co commented 7 years ago

Added property to PAS Cell object called Mod Freq - this will hold the modulation frequency selected by the user. This value is updated in the command Change Laser Frequency found in the ePAS Library. It will be the value that will be used by PAS Cell Data::Get Integrated Area method.

lo-co commented 7 years ago

Added new input to PAS Cell Data::Get Integrated Area method called fmod - it is a single precision variable that represents the modulation frequency. The input is optional with a default of 0, but if the value is populated, it will be used to calculate the integrated area. In PAS::Analyze Data, this value is connected to the new property defined above. For former behavior, you should be able to simply disconnect the value.