search

msramalho / SigTools

📆 Sigarra Tools | An extension that makes the information system of the University of Porto slightly better.
https://chrome.google.com/webstore/detail/sigarra-to-calendar/piefgbacnljenipiifjopkfifeljjkme
Apache License 2.0
37 stars 0 forks source link

Add support for lack of event's location #48

Closed fabiodrg closed 2 years ago

fabiodrg commented 5 years ago

Not sure, but I think all extractors in Sigarra have some sort of location, typically a classroom. However, that assumption isn't verified in Moodle, and as a workaround the current location is Moodle. Would be nice to handle this more properly.

The Google Calendars link and Outlook don't require the location parameter. The standard for ICS almost sure it doesn't require it either, although not sure if the library we are using has limitations.

msramalho commented 5 years ago

I don't think it has that limitation. In any case, one could always change it to "".

I believe I left it as "Moodle" in lack of something more informative as, for instance, some events are like homework on moodle, exam on moodle, delivery on moodle, ...

fabiodrg commented 5 years ago

Ok, that makes some sense. Maybe this could be a setting in the options page?

msramalho commented 5 years ago

Agreed, and that should be straightforward to implement!