msramalho / SigTools

📆 Sigarra Tools | An extension that makes the information system of the University of Porto slightly better.
https://chrome.google.com/webstore/detail/sigarra-to-calendar/piefgbacnljenipiifjopkfifeljjkme
Apache License 2.0
37 stars 0 forks source link

Fix browsers blocking GET requests on files/html due CORS #94

Closed fabiodrg closed 2 years ago

fabiodrg commented 2 years ago
fabiodrg commented 2 years ago

I am converting this to a draft because I detected a potential conflict with datatables and other extractors. For instance, the exam extractor. I will look into it later today. I will probably push into this PR because I did some fixes in datatables here, soo.. just preventing git conflicts

fabiodrg commented 2 years ago

Issue went away. Indeed applying DataTable was clashing with the bills extractor. But since DataTable fails, after performing the cleaning, the bills extractor still works. Nonetheless, I think we should review all extractors contexts and block DataTables if (a) data tables don't make sense on some specific page (i.e. exams page) or if there is any chance of conflicts (e.g. bills, which in fact we know in advance it will fail anyway). Will do that tomorrow