msramalho / SigTools

📆 Sigarra Tools | An extension that makes the information system of the University of Porto slightly better.
https://chrome.google.com/webstore/detail/sigarra-to-calendar/piefgbacnljenipiifjopkfifeljjkme
Apache License 2.0
37 stars 0 forks source link

Review DataTable selector #96

Open fabiodrg opened 2 years ago

fabiodrg commented 2 years ago

While I was searching in research projects pages, I noticed DataTable was not applying. The table has a class tabela. The DataTable extractor uses table.tabela:has(tr.i). So the reason why the table in search results is not considered, it is because the rows lack the i and p classes. As far as I can tell, these classes extend to 'impar' and 'par', just for colouring the table rows. Therefore, I wonder if we can update the selector to table.tabela.

Page: https://sigarra.up.pt/feup/pt/projectos_geral.lista_projectos?p_id=&p_referencia=&p_sigla=&p_titulo=&p_tipo=&p_financ_compet=&p_estado_proj=&p_estado=&p_inicio_a=&u_inicio_a=&p_fim_prev_a=&u_fim_prev_a=&p_fim_a=&u_fim_a=&p_id_programa=&p_area_cordis_id=&p_area_cordis=&p_accao=&p_servico=&p_area_fos_id=&p_area_fos=&p_pal_chave=&p_resumo=&p_moeda=&p_orc_global=&u_orc_global=&p_orc_uo=&u_orc_uo=&pv_ambito_geo=&pv_ambito_geo_financ=&p_id_inst_financia=&pi_cod_pessoa=&pv_nome_pessoa=&pi_cod_pessoa_tecnico=&pv_nome_pessoa_tecnico=&p_id_inst_parceira=&p_sigla_inst_financia=&p_nome_inst_parceira=&pi_inst_id=509&pv_inst_sigla=FEUP&pv_inst_nome=Faculdade+de+Engenharia+da+Universidade+do+Porto&p_cod_uni=&p_cur_sigla=&p_n_registos=50&z_start=1&p_ord=titulo+asc&p_exp=0&pv_num_pag=1&pv_ambito_geo=&pv_ambito_geo_financ=&pv_cfunc_id=&pv_cfunc_cod=&pv_cfunc_des=

fabiodrg commented 2 years ago

This also applies to the infinite scroll extract