search

mssiegel / Frempco-web-client

Frontend for frempco.com
https://www.frempco.com/
3 stars 0 forks source link

Updated classrooms.json #18

Closed leahnp613 closed 1 year ago

leahnp613 commented 1 year ago

1 Added demo classroom and comments for test & demo classrooms.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
frempco ✅ Ready (Inspect) Visit Preview Jan 10, 2023 at 3:49PM (UTC)
leahnp613 commented 1 year ago

Looks great! Two minor things:

  • If you can change the PR to merge it into "dev". Because all PRs get initially merged into Dev. and then on weekends we merge from dev into main.
  • If you can edit your initial comment under "conversation" tab to include a link to the Github issue. #1 (Here's a shortcut to link it fast: If you just type the # symbol Github will automatically pull up the list of issues which makes it very fast to link)

Done.

mssiegel commented 1 year ago

Approved. Go ahead and merge. Thanks! Once its merged you can close the issue.