passforios 0.10.0 can no longer find the right key to use, but has the right key stored when hitting "select key"

beeaniebee commented 3 years ago

It seems like my phone has updated automatically, which broke passforios for me. I was trying to unlock a password when I got the notification that "PGP private key (xxxx) not found" where xxxx is the ID for the key. When I hit "Select Key", and could hit the top of (of two) with a different ID, and the password would unlock. Pass itself works fine on my system, and can unlock everything just fine, and I even re-exported my keys which had the right ID number when running gpg -k to no avail. I would really like to be able to use passwords on my phone

beeaniebee commented 3 years ago

I made a new test password using the app, and selected the "right" key to use, put in the right password, and it encrypted just fine. I pushed to my remote repository, pulled from my computer, and was able to decrypt it just fine. However, using the exact same key and password seconds after encrypting it on the app, it can no longer decrypt the password, saying "decrypted hash mismatch, invalid passphrase" even though I'm 100% sure it's right. Using the same key and password to decrypt my previous passwords work just fine.

beeaniebee commented 3 years ago

to add on to weirdness, any of the keys in password store, which has a folder encrypted with a different gpg key, can be unlocked with either gpg key selected after the error, as long as it's using the right passphrase for what the right key should be. I thought that the first short key id was my main gpg id, because it would unlock with the password for my main key, but it turns out I was decrypting the passwords with the key for the single folder, but using the passphrase for my main key.

mssun commented 3 years ago

Thanks for your report. The new version will read the .gpg-id file for key ID first. What's the content of it? Thanks.

KizzyCode commented 3 years ago

I have a similar bug. There are three keys:

pass-synced@kizzycode.de (my in-software pass key, which is used for pass and passforios)
keziah@kizzycode.de (my Yubikey backed key)
escrow@kizzycode.de (a full-offline key for emergency recoveries)

My repo looks like this:

├──.gitattributes
├──.gitignore
├──.gpg-id
└──Websites
        ├──.gpg-id
        └── autodesk.com

The contents of .gpg-id are

156947E8
EA9EB384
6AB083C3

My public key import (via iTunes) is:

On my iPhone it always asks me to select the secret key (even if I have only the pass-synced@kizzycode.de private key imported) – that's a bit annoying, but it works 😅. On my iPad (6th generation) however, the app simply crashes when I press "Select key" 😕

Edit: Crash log Pass-2021-01-07-141733.ips.txt

mssun commented 3 years ago

Thanks @KizzyCode, this is very helpful!

mssun commented 3 years ago

Hi, I have uploaded a quick fix for the .gpg-id related issue. I need some time for a better solution. Thanks.

beeaniebee commented 3 years ago

Thank you! I hope it goes well. Do I need TestFlight or something to be able to update from the AppStore?

mssun commented 3 years ago

Yes, you can get it via this link: https://testflight.apple.com/join/whK4zUFG

beeaniebee commented 3 years ago

The decryption part of the issue is fixed in the latest two builds, 6 & 8, but not the encryption. When creating a new password, pass beta will still notify that it can't find the correct pgp public key, and after selecting the correct one, not even the correct password will be able to decrypt the password. It's also unable to decrypt passwords created on pass and vice versa that has this issue as well, even though the command line utility is able to decrypt the passwords that are created this way.

mssun commented 3 years ago

Thanks @BeanieBen9990. Yes, this .gpg-id feature is not ready. I'll fix it.

beeaniebee commented 3 years ago

Gotcha. Just got the update and encrypting a password now correctly identifies the right pgp key to encrypt with, but still cannot decrypt the password after creation and encryption. Still, creating a key will be able to be decrypted with the command line utility, but not with the app, beta or not.

mssun commented 3 years ago

Do you import multiple PGP keys?

beeaniebee commented 3 years ago

I do. Sorry for being late on that reply. Two keys, one for most of them, and then I have a separate folder within the password store that encrypts with a second key. Both are imported using the same .key file though, one for private and one for public

aikijuanma commented 3 years ago

I've been having this problem for some time now. How can I get the quick fix? Thank you!

aikijuanma commented 3 years ago

How can I help you test beta versions through TestFlight? The current link says: "This beta isn't accepting any new testers right now". Should I build it myself? Thank you!

mssun / passforios

passforios 0.10.0 can no longer find the right key to use, but has the right key stored when hitting "select key" #448