mstable / mStable-apps

All mStable apps
GNU Lesser General Public License v3.0
14 stars 24 forks source link

MTA Apy not correct when rewards are not updated #205

Closed dimsome closed 2 years ago

dimsome commented 2 years ago

Describe the bug Many dials got disabled, however, the UI still shows the same APY for MTA rewards. This is because the rewards Rate does not get updated anymore. The UI has to be aware that if the last time the rewardsRate was updated longer than 7 days, the rewards are empty and no new rewards got added.

To Reproduce Steps to reproduce the behavior:

https://mstable.app/#/mbtc/save

https://mstable.app/#/mbtc/pools

https://mstable.app/#/musd/pools

Also Single Pools Page, e.g. https://mstable.app/#/musd/pools/0x4eaa01974b6594c0ee62ffd7fee56cf11e6af936

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

Screen Shot 2022-08-29 at 15 14 41

Screen Shot 2022-08-29 at 15 14 49

Screen Shot 2022-08-29 at 15 15 06

calvinkei commented 2 years ago

hi @dimsome , just checking if this looks correct. imBTC save APY is still >0% because it's last updated less than 7 days ago

Screenshot 2022-08-29 at 6 03 42 PM
dimsome commented 2 years ago

I think all of them should be now 0%.

calvinkei commented 2 years ago

@dimsome you mean removing the Rewards APY row like this?

Screenshot 2022-08-29 at 7 13 35 PM
dimsome commented 2 years ago

yup, that looks alright