mstange / pdb-addr2line

A rust crate to symbolicate addresses from PDBs, like addr2line. Uses the `pdb` crate.
https://docs.rs/pdb-addr2line
Apache License 2.0
33 stars 4 forks source link

Allow Context/ContextPdbData to impl Send. #63

Closed afranchuk closed 11 months ago

afranchuk commented 1 year ago

This allows wholesym structures to be Send, which is necessary to use them across await points.

mstange commented 1 year ago

This looks good but merging it would mean that I can't do a new release to crates.io until the pdb dependency is switched out for a regular crates.io dependency again.

afranchuk commented 1 year ago

Yeah. I contacted Will Glynn but I've got no response. I'm hoping they're just on vacation or something.

afranchuk commented 1 year ago

Just updated things to use the pdb2 crate.

afranchuk commented 1 year ago

@mstange this ought to be ready for merge.

mstange commented 11 months ago

Quite unfortunate that we had to do a pdb2, but we've waited long enough.

Thanks for the patch and sorry for the huge delay!

afranchuk commented 11 months ago

Agreed, but thank you!