mstange / samply

Command-line sampling profiler for macOS and Linux
Apache License 2.0
1.98k stars 48 forks source link

Don't add markers for unknown ETW events #218

Closed vvuk closed 1 month ago

vvuk commented 1 month ago

These are useful for debugging and might be a nice command line option in the future, but for now they just add random Image/UnLoad and Process/Terminated events which aren't useful

mstange commented 1 month ago

Would you be happy if we just ignored UnLoad and Terminated? I think @jrmuizel likes to experiment with different xperf start settings and then it's convenient to just have the new markers show up immediately.

vvuk commented 1 month ago

Yeah, I was actually thinking of just adding a command line flag to make markers for unknown things, because it is pretty useful. Would that work? Specifically:

? I'd like an option instead of doing it unilaterally so that if I'm importing an etl file created elsewhere, it may contain lots of events that I don't care about at all, but may end up as a large volume of markers.

vvuk commented 1 month ago

Ok, reworked this to add the command line option; let me know if that works.