Box the future from .bytes() to reduce stack usage

mstange / symsrv

Download pdbs from symbol servers and cache locally, parse symbol paths from env vars

Apache License 2.0

21 stars 2 forks source link

Box the future from .bytes() to reduce stack usage #8

Open mstange opened 1 year ago

mstange commented 1 year ago

This was pointed out by Wesley Wiser:

Yeah, Bytes (the struct) is very small but the future returned by .bytes() is ~11kb if you have the brotli feature enabled. Filed an issue upstream so hopefully we can get that fixed!

https://twitter.com/wesleywiser/status/1572626207077703680

We should check if the upstream fix happened or whether we should land the workaround here.