Fix `grunt serve` task - Githubissues

mstefaniuk / graph-viz-d3-js

Graphviz web D3.js renderer

MIT License

313 stars 38 forks source link

Fix `grunt serve` task #3

Closed kitop closed 9 years ago

kitop commented 9 years ago

Add the base path (app) to nodestatic-serve task. Before this, it was failing to find require.js when you visited http://localhost:9999/app.

This change fixes that, but introduces a few other things:

Now the homepage is the editor. (no more /app)
No access to /demo
- demo and app are the same thing right now, so it was basicaly duplicating things.
- This doesn't remove the demo yet, but can be done if we think it's no loger needed.

coveralls commented 9 years ago

Coverage remained the same at 73.74% when pulling 3f5e14b6e9509852f4f75df4a2dbf5ee86bf7b09 on kitop:grunt-serve-fix into 5bfed143840c1e8c9b1ff61564fe11af5a7f5d2c on mstefaniuk:master.

mstefaniuk commented 9 years ago

Thanks. I'm accepting this pull request. Serve task is now obsolete because app is served by hoodie.

kitop commented 9 years ago

Ah, gotcha! Thanks for the info :)