jim-readline.c fails to compile with GCC 14 as it does not include stdio.h

msteveb / jimtcl

Official repository of Jim Tcl, an open-source, small footprint implementation of Tcl

http://jim.tcl.tk/

Other

428 stars 121 forks source link

jim-readline.c fails to compile with GCC 14 as it does not include stdio.h #309

Closed michel-slm closed 2 hours ago

michel-slm commented 2 hours ago

readline's documentation specifies that applications should include stdio.h before including readline:

https://git.savannah.gnu.org/cgit/readline.git/tree/doc/readline.info?h=readline-8.2&id=f7a382fd09319b20ef4435b9b554183b605468c1#n1735

jim-readline.c does not, and it must have worked before because stdio.h was transitively included via some other path, and this no longer works when attempting to update jimtcl to 0.83 in Fedora. It probably should be fixed in jimtcl, I'll send the PR.

michel-slm commented 2 hours ago

Ah, fixed in a post-release commit

https://github.com/msteveb/jimtcl/commit/35e0e1f9b1f018666e5170a35366c5fc3b97309c

note: per what readline author said this is by design, and is documented, though I do agree I expect including a header should include all the definitions it needs