search

mstinaff / PMS_Updater

Shell script for updating the Plex Media Server inside the FreeNAS Plex plugin
MIT License
439 stars 91 forks source link

Fix PMS_Updater for Newer Versions of Plex Plugin #54

Closed Zzyzx-Wolfe closed 1 year ago

Zzyzx-Wolfe commented 4 years ago

In newer installs of the Plex Plugin, rather than putting the Plex Media Server folder under /, it's either under /usr/local/plexdata/ or /usr/local/plexdata-plexpass/. This update checks all three locations for the preferences file so that it can correctly grab the token in these situations.

A9G-Data-Droid commented 3 years ago

I have tested this on Version: TrueNAS-12.0-U2.1

I can confirm that "it just works".

If my opinion mattered I would vote to merge this PR.

cascer1 commented 3 years ago

What's the point of even including the token in the request? I get the same response from the API when I don't send a token.

jbeez commented 3 years ago

In newer installs of the Plex Plugin, rather than putting the Plex Media Server folder under /, it's either under /usr/local/plexdata/ or /usr/local/plexdata-plexpass/. This update checks all three locations for the preferences file so that it can correctly grab the token in these situations.

Slightly modified your pull to work with my fork and added it in, TY @Zzyzx-Wolfe

jbeez commented 3 years ago

What's the point of even including the token in the request? I get the same response from the API when I don't send a token.

its supposed to be for plexpass customers to download the newer version file

cascer1 commented 3 years ago

What's the point of even including the token in the request? I get the same response from the API when I don't send a token.

its supposed to be for plexpass customers to download the newer version file

I guess there's an implementation issue there on Plex' side because I can download the plexpass version without token.

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.