mstinaff / PMS_Updater

Shell script for updating the Plex Media Server inside the FreeNAS Plex plugin

MIT License

442 stars 90 forks source link

Fixed download by working around environment issues #59

Closed jbeez closed 3 years ago

jbeez commented 3 years ago

Had to work around plex python environment not reading my variables, used ln -s to move python27.zip file to python binary's current directory, seems to work great no issues in testing.

jarodwsams commented 3 years ago

I can confirm that this commit fixes #57.

Zzyzx-Wolfe commented 3 years ago

Tested and working for me. Though, as a small note, if someone originally installed the non-PlexPass package originally, it won't find their token. /usr/local/plexdata/Plex Media Server/Preferences.xml is a third possible path, for completeness. They should pass -n if they want the non-PlexPass version.

54 was my hacky fix of that issue a while back.

CognitiveFeline commented 3 years ago

works great

MAGICCC commented 3 years ago

@jbeez would you like to implent the check from @Zzyzx-Wolfe so we can merge this or would it better to use #54?

Zzyzx-Wolfe commented 3 years ago

@jbeez would you like to implent the check from @Zzyzx-Wolfe so we can merge this or would it better to use #54?

Looking at @jbeez's fork, it looks like they added it, but have not added the commits to the PR: https://github.com/jbeez/PMS_Updater/tree/TokenAuth

MAGICCC commented 3 years ago

@jbeez would you like to implent the check from @Zzyzx-Wolfe so we can merge this or would it better to use #54?

Looking at @jbeez's fork, it looks like they added it, but have not added the commits to the PR: https://github.com/jbeez/PMS_Updater/tree/TokenAuth

Ah yes, you are right :(

jbeez commented 3 years ago

Hey guys, I'll try to review this shortly when I get a little time and add the changes to this PR :)

MAGICCC commented 3 years ago

Thanks!