mstksg / backprop

Heterogeneous automatic differentiation ("backpropagation") in Haskell
https://backprop.jle.im
BSD 3-Clause "New" or "Revised" License
180 stars 22 forks source link

Do not use Data.Semigroup.Option type on base >=4.16.0.0 (i.e. GHC >=9.2.1) #20

Closed msakai closed 1 year ago

msakai commented 2 years ago

As @Mikolaj reported on https://github.com/mstksg/backprop/pull/19#issuecomment-1010063543 , the current master branch fails to compile on GHC 9.2 not only due to the simplified subsumption (#19) but also due to the removal of Data.Semigroup.Option on base >=4.16.0.0.

See also:

This PR fixes the latter problem.

I confirmed that GHC 9.2 can compile this PR + #19 with Vinyl 322476778d11223ac40f1e1c3faddc007eaef72a (I did not use the master branch of Vinyl because of https://github.com/VinylRecords/Vinyl/issues/157) + https://github.com/VinylRecords/Vinyl/issues/156 fix.

Mikolaj commented 2 years ago

Vinyl presumably has this [edit: compatibility with GHC 9.2.1] fixed in the just released version.

Bodigrim commented 1 year ago

@mstksg any chance to merge this please? (As a Hackage trustee I revised existing releases with base < 4.16 to prohibit unbuildable configurations)

mstksg commented 1 year ago

thanks! :) apologies for the delay!