search

mstorsjo / msvc-wine

Scripts for setting up and running MSVC in Wine on Linux
Other
683 stars 83 forks source link

Convert clang-cl tests to the test scripts, add tests for tricky header casing #75

Closed mstorsjo closed 1 year ago

mstorsjo commented 1 year ago

CC @huangqinjin

mstorsjo commented 1 year ago

I pushed updates now, taking advantage of the improvements to the scripts as you made, and applying your feedback. Thanks!

mstorsjo commented 1 year ago

FWIW I'll probably leave out the headers.cpp test from the cmake file (leaving out the last commit before merging, if the rest is ok with you) as it is a bit messy and doesn't add much extra test coverage.

huangqinjin commented 1 year ago

leave out the headers.cpp test from the cmake file

I second this. And LGTM!