Convert install scripts to python

mstorsjo / msvc-wine

Scripts for setting up and running MSVC in Wine on Linux

Other

665 stars 82 forks source link

Convert install scripts to python #89

Open AgentK9 opened 1 year ago

AgentK9 commented 1 year ago

Python is more universal than perl and allows for better extensibility and portability, not to mention readability.

mstorsjo commented 1 year ago

I'm somewhat ambivalent about this PR. (I haven't studied your suggested code in detail yet.)

Yes, python is probably to prefer over perl for the fixinclude and lowercase scripts. But for the install.sh script, I'm not really sure about whether this is a net win or loss - what do we gain from converting that to python?

(The actions run that I just enabled will probably fail; this is due to a tool regression that I've worked around on master; if you rebase your branch on latest master, it should run successfully again.)

AgentK9 commented 1 year ago

Hello,

Thanks so much for your time in reviewing this. I have merged main into my branch. If you'd like, I can also squash all of these commits.

Here are a few reasons why the install.sh script should be changed along with the others:

Unified Codebase: Aligns with the existing Python components, streamlining maintenance.
Inclusivity: Facilitates contributions from Windows developers unfamiliar with GNU shell/sh.
Versatility: Enhances portability and allows for future feature integrations with ease.

I'd really appreciate any feedback you have.

SaifRushdHadad commented 5 months ago

I'm somewhat ambivalent about this PR. (I haven't studied your suggested code in detail yet.)

@mstorsjo, I was wondering if you had reviewed the suggested changes? I know it has been some time since the PR was submitted but rebasing and updating should be doable.