search

mstratman / jQuery-Smart-Wizard

flexible jQuery plug-in that gives wizard like interface
http://mstratman.github.com/jQuery-Smart-Wizard/
303 stars 164 forks source link

fixHeight() does not consider margins #63

Closed beldougie closed 10 years ago

beldougie commented 10 years ago

Hi, the fixHeight() method does not take the margins of child elements in the steps into account when calculating the height of a step. This means that content can easily slip out of the bottom of the step.

The fix is easy, the jQuery.outerHeight() function has an optional boolean argument that is false by default but if set to true will take margins into account.

Let me know if you want a pull request with a patch for this.

mstratman commented 10 years ago

Thanks for catching this. A pull request would definitely be appreciated.

sp4ceman commented 10 years ago

his fix is a one liner, on line 414 in the fixheight method. currently its : height += $(this).outerHeight(); make it this : height += $(this).outerHeight(true);