If XDG_CACHE_HOME is not defined, I believe it will try to delete /tldr from root folder

mstruebing / tldr

Golang command line client for tldr https://github.com/tldr-pages/tldr

MIT License

262 stars 23 forks source link

If XDG_CACHE_HOME is not defined, I believe it will try to delete /tldr from root folder #51

Closed danielwangksu closed 4 years ago

danielwangksu commented 4 years ago

It might not hurt anything, but no a good idea to do and it is not the code intention

https://github.com/mstruebing/tldr/blob/afe0c461cbfe10ab62bbf4b3feebf3367563b0b7/Makefile#L65

mstruebing commented 4 years ago

Hey @danielwangksu thank you for your issue :rocket:

I can see your concern, but as this only will be executed by developers of that software it is not so harmful as that's no user facing code. However, I understand that this can happen, if you want, you can provide a PR for it.