search

mstruebing / tldr

Golang command line client for tldr https://github.com/tldr-pages/tldr
MIT License
262 stars 24 forks source link

Add history function for the past page view. #53

Closed wudong closed 3 years ago

wudong commented 4 years ago

What I did: Add history function into tldr.

Why I did it: Often I want to review what I have searched, and to see if there are some information I should remember instead going back to tldr constantly. This history function keeps the history for what I have searched and allow me to review easily later.

codecov-commenter commented 4 years ago

Codecov Report

Merging #53 into master will decrease coverage by 2.79%. The diff coverage is 62.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   62.70%   59.90%   -2.80%     
==========================================
  Files           3        3              
  Lines         185      222      +37     
==========================================
+ Hits          116      133      +17     
- Misses         44       57      +13     
- Partials       25       32       +7
Impacted Files Coverage Δ
cache/cache.go 53.37% <62.26%> (+0.03%) :arrow_up:
platform.go 77.77% <0.00%> (-3.18%) :arrow_down:
render.go 92.30% <0.00%> (-0.80%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c123be...6486b18. Read the comment docs.

wudong commented 3 years ago

Hi @mstruebing, all very valid points, thanks a lot. I have address the comments now.