search

mstruebing / tldr

Golang command line client for tldr https://github.com/tldr-pages/tldr
MIT License
262 stars 24 forks source link

Add Android platform; Import testify; Fix tests #58

Closed conves closed 3 years ago

conves commented 3 years ago

What I did:

  1. I added Android to the list of available platforms, as it was breaking tests.
  2. I imported testify. (MIT)
  3. I also refactored the TestAvailablePlatforms function to table driven tests.

Why I did it:

  1. I think this is the recent PR to tldr-pages that added Android and started breaking tests.
  2. I'm using testify extensively in other projects, and it just makes my life way easier. :)
  3. Table driven is the idiomatic way of writing tests in Go.