msupply-foundation / conforma-server

Conforma application manager (IRIMS) back-end
GNU Affero General Public License v3.0
4 stars 1 forks source link

Server valid email regex checker more strict than front end checkers #1047

Open fergie-nz opened 1 year ago

fergie-nz commented 1 year ago

Conforma server currently checks if emails are valid with a regex expression which can be more strict than front end checks.

In the create internal user workflow (angola snapshot, and possibly other cases), it will fail quietly with certain email addresses when attempting to create a new account.

The form will appear to be processed but will not create a new user as no valid emails are found.

Easiest fix in this case is probably to update the regex expression in the front end also, however this is liable to happen elsewhere when these expressions are changed.

I am thinking best outcome is more loudly failing when email is invalid.

CarlosNZ commented 1 year ago

Where is this in the Server? I don't remember there being any additional checks.