#1103 Memoise list actions

msupply-foundation / conforma-server

Conforma application manager (IRIMS) back-end

GNU Affero General Public License v3.0

4 stars 1 forks source link

#1103 Memoise list actions #1106

Closed CarlosNZ closed 5 months ago

CarlosNZ commented 6 months ago

Fix #1103

I'll add some explanatory comments in the PR (in addition to the in-code comments)

To test, play round with:

assigning (to self and others)
starting review
submitting review
re-submit application after change requests (as applicant)

After each of these events, note the changes to the application_reviewer_action table, and the reviewers/assigners lists on the application table.

CarlosNZ commented 5 months ago

Thanks for the review @andreievg -- have replied to or fixed your suggestions. Couple of them I wasn't totally clear what you're referring to, so come chat IRL if you want to clarify further.

CarlosNZ commented 5 months ago

Cool, @andreievg , thanks for a thorough look through

This suggest that majoriy have at least 14 assigners.

I actually think that's probably too high in practice. They've been a bit loose with handing out permissions in Fiji, we can probably get that down.