search

msupply-foundation / conforma-server

Conforma application manager (IRIMS) back-end
GNU Affero General Public License v3.0
4 stars 1 forks source link

#1104 Index fixes #1109

Closed CarlosNZ closed 5 months ago

CarlosNZ commented 5 months ago

Fixes duplicate indexes that have accumulated due to a dodgy UNIQUE constraint.

I also made a few tweaks to existing migrations to minimise reported errors.

(You should be able to run yarn migrate 0.0.0) and not have anything break.

CarlosNZ commented 5 months ago

Hmm, @andreievg I just noticed this is based of your branch which is now closed. Might have to be careful when rebasing in case this has pulled in changes we don't want.

CarlosNZ commented 5 months ago

Hmm, @andreievg I just noticed this is based of your branch which is now closed. Might have to be careful when rebasing in case this has pulled in changes we don't want.

Okay @andreievg , I've rebased this off my earlier PR now, and reverted all the changes from your now-obsolete PR.

andreievg commented 5 months ago

Okay @andreievg , I've rebased this off my earlier PR now, and reverted all the changes from your now-obsolete PR.

Thanks @CarlosNZ. Sorry I thought that my changes were independent, didn't realise it was a base, otherwise would have made the changes in that base branch. Maybe we can do another branch for build and merge all the pending PRs to it, might help in avoiding these sorts of conflicts