search

msupply-foundation / conforma-server

Conforma application manager (IRIMS) back-end
GNU Affero General Public License v3.0
4 stars 1 forks source link

Un-assignment available for final decision. Causes form failure #943

Open fergie-nz opened 1 year ago

fergie-nz commented 1 year ago

Possible front end changes also required to remove button from un-assignment.

Un-assignment should not be available or visible.

Here the application is assigned to all users, yet admin is able to unassign Screen Shot 2022-11-03 at 10 50 00 AM (2)

Admin unassigns and application fails Screen Shot 2022-11-03 at 10 50 12 AM

CarlosNZ commented 1 year ago

Okay, as mentioned in the meeting earlier today, allowing multiple people to be auto-assigned to a section breaks the integrity of the back-end and (in my opinion) creates more problems than it solves.

In fact, with this PR, being able to auto assign multiple people to the same review/stage/level will not be allowed.

Strongly suggest going back to the original behaviour where reviewers are simply "AVAILABLE" for assignment and have to self-assign themselves like they do everywhere else.

If anyone has a good reason why this shouldn't be like this, please explain it here. Cos allowing the database to exist in an inconsistent and problematic state (just look how many assignment bugs we cause!!) in order to save a user a couple of clicks is not worth it, so the argument for this will need to be pretty compelling.

CarlosNZ commented 1 year ago

See also this issue, which is related: https://github.com/openmsupply/conforma-web-app/issues/1423

We need to sort this ASAP -- should be #1 priority for the start of this week.

CarlosNZ commented 1 year ago

I think this has been sorted. Someone should check at some point, please, and close issue if so.