Offer users to finalise supplier invoices when viewing them

msupply-foundation / mobile

Open source mobile app for medical inventory control

http://msupply.org.nz/mobile

Other

42 stars 27 forks source link

Offer users to finalise supplier invoices when viewing them #1103

Open craigdrown opened 5 years ago

craigdrown commented 5 years ago

problem?

Users forget to finalise >> no stock

Describe the solution you'd like

Remind the user with a dialog when tapping the back button?

GaryWilletts commented 5 years ago

Might work. Depends on how often a user opens a supplier invoice when they don't want to finalise it against how often they open one when they do want to finalise it. Not just a training issue? Getting close to straying into "just use it properly, don't ask us to change the system because you don't use it properly" territory.

josh-griffin commented 5 years ago

I think it's a pretty common UX feature that when navigating away from some sort of document, there is a prompt for saving before you navigate away. I think the way our pages are currently designed they're similar in concept and having a prompt to finalize before navigating away would be a familiar feature.

In saying that, I think our pages should be changed to be more of a wizard, personally. Where this wouldn't be needed!

josh-griffin commented 5 years ago

Questions for this issue specifically:

All finalizable pages, or just Supplier Invoice? I say all, to keep consistency and familiarity for the user.
Is this for 3.0? It has a high priority so I'd assume there's a problem somewhere

Implementation:

Use the simple modal component we use now for finalizing, with different text and ok/cancel?
- "You haven't finalized this X, do you want to?" with ok/no - other suggestions?
Capture the backhandler event, check if finalized and prompt if not
Finalize straight from that modal, rather than having the real finalize modal appear

Chris-Petty commented 5 years ago

Badges would also help here and there is a PR for that already, but on the back burner!

Rebecca367 commented 4 years ago

@joshxg @craigdrown @diegoevangelisti Sorry, just curious about this issue. Are there any existing ways of implementing it? So far, there is non pop-up dialog showing that "Are you wanna finalise...?" the same one as it is in desktop when you click on the back button. Here is a thought. Due to user just do as convenient as they could and they certainly and most likely won't follow rules, so it would be a good idea to have a pop-up window asking them to select before they leave invoices but if this is introduced to mobile right now, does it mean that it needs to include in CI and stocktake as well and how?

josh-griffin commented 4 years ago

@Rebecca367 I'm not sure exactly what you are asking, however the list of issues which we are looking to do for the next release is here: https://github.com/openmsupply/mobile/issues/2445 - or under the 5.0.0 milestone