TESTING: Supplier Requisitions Page

[josh-griffin]

TESTING

This is an issue for testing SupplierRequisitionsPage.

Please copy and paste this list of tests and post your results in a comment in this issue.

TESTER NOTES:

• Ensure one of the EXTERNAL SUPPLIERS (Name record which is a facility, NOT a store, and is a supplier) has a very long name
• If testing both SupplierRequisitionPage and SupplierRequisitionsPage, will be faster to do them both without programs first and then with programs after

Supplier Requisitions Page

This page should be tested WITH NO PROGRAMS and WITH PROGRAMS. Alterations to the behaviour of this page are listed at the BOTTOM of this list.

NAVIGATION

• [ ] Can navigate to this page through the Menu Page, "Supplier Requisition" button
• [ ] Pressing either the top left back button, or hardware back button navigates to the Menu Page
• [ ] Navigating to this page from a supplier requisition shows the correctly updated details (finalise or add items to a supplier requisition, navigating back shows that supplier requisition as finalised or the increase in items)

SYNC

• [ ] Supplier requisitions are synced to desktop
• [ ] Supplier requisitions are synced from desktop

Table

• [ ] List all supplier requisitions for this store (matches internal orders list in desktop)
• [ ] Initial sort is by requisition number in descending order

Row Press

• [ ] Pressing a row (except for the "DELETE" column), navigates to the SupplierRequisitionPage
• [ ] The supplier requisition navigated to is the row that was pressed

Filtering

• [ ] Supplier requisitions are filtered by requisition number when a search term is entered
• [ ] Filtering is cleared when the search term is cleared [by backspacing or pressing the X].

Columns

• [ ] REQUISITION NUMBER
  • [ ] Sortable (and sorts correctly)
  • [ ] New requisitions are correctly incremented (customer and supplier requisitions share numbers)
  • [ ] Sorting icon updates correctly to indicate ascending/descending and no sorting
  • [ ] Cells are NOT editable
  • [ ] Left aligned
• [ ] SUPPLIER
  • [ ] Sortable (and sorts correctly)
  • [ ] Supplier names are correctly listed for every supplier requisition
  • [ ] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [ ] Cells NOT editable
  • [ ] Text overflow handled (create a Supplier name that is very long)
  • [ ] Left aligned
• [ ] PROGRAM (NOTE: only displays if at least one requisition is associated with a program)
  • [ ] Does not display if no requisitions are associated with a program (includes current AND past requisitions)
  • [ ] Displays if at least one requisition is associated with a program (includes current AND past requisitions)
  • [ ] Sortable (and sorts correctly)
  • [ ] Programs are listed correctly for every customer requisition ("N/A" if requisition has no program)
  • [ ] Sorting icon updates correctly to indicate ascending/descending and no sorting
  • [ ] Cells are NOT editable
  • [ ] Text overflow handled (create a program name that is very long)
  • [ ] Left aligned
• [ ] ITEMS
  • [ ] Sortable (and sorts correctly)
  • [ ] Shows the correct number of items in the supplier requisition
  • [ ] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [ ] Right aligned
  • [ ] Number of items is correctly updated (when navigating back from a supplier requisition)
• [ ] ENTERED DATE
  • [ ] Sortable (and sorts correctly): this might be difficult if the data file is new or there are no old records, so clicking the sort button and having the icon change is sufficient
  • [ ] Shows the correct date an invoice was created
  • [ ] Dates are in the form: WeekDay Month Year, e.g. 17 May 2008
  • [ ] Sorting icon updates correctly to indicate ascending/descending and no sorting
  • [ ] Left aligned
  • [ ] Cells are NOT editable
• [ ] STATUS
  • [ ] NOT sortable
  • [ ] Shows the correct status for an invoice
  • [ ] Status is one of: "In Progress" or "Finalised" (or localised equivalents)
  • [ ] Left aligned
  • [ ] Cells are NOT editable
• [ ] Delete
  • [ ] NOT a sortable column
  • [ ] Cells NOT editable
  • [ ] Finalised invoices are not selectable
  • [ ] Finalised rows indicate they are not selectable
  • [ ] Rows not finalised are selectable
  • [ ] Multiple rows are selectable
  • [ ] Selecting a row opens a confirmation dialog at the bottom of the page
  • [ ] Unselecting all rows closes the confirmation dialog at the bottom of the page
  • [ ] Confirming the confirmation dialog deletes the supplier requisitions
  • [ ] Cancelling the confirmation dialog removes the current selection and closes the confirmation dialog
  • [ ] Finalised invoices are not selectable

Buttons

• [ ] "New Requisition"
  • [ ] Button is displayed.
  • [ ] On press, button opens "Select a supplier" modal

Modals

• [ ] New Requisition Modal
  • [ ] Title is "Select a supplier"
  • [ ] Options to select are names records that are: VISIBLE, a SUPPLIER, not THIS store and a STORE type
  • [ ] Search Bar is auto focused on opening
  • [ ] Closing the modal, closes the modal
  • [ ] Filtering the list, filters by supplier name.
  • [ ] Clearing the search term clears filtering
  • [ ] Clicking a customer creates a new supplier requisition and navigates to a SupplierRequisitionPage with the newly created supplier requisition open

WITH PROGRAMS

Note: Having a program: Having a master list which is a program related to the store with a store tag matching a tag in this stores tag

Buttons

• [ ] "New Requisition"
  • [ ] Button is displayed
  • [ ] On press, button opens ByProgramModal

Modals

• [ ] ByProgramModal
  • [ ] Must select steps in order: program, supplier, order type, period
  • [ ] Can back pedal steps, where the progress is adjusted correctly
  • [ ] Only order types which are defined for a program are displayed
  • [ ] Only periods for the order type defined are displayed
  • [ ] Order types, when being selected show the correct details (MOS etc.)
  • [ ] Periods, when being selected show the correct details (number of requisitions etc.)
  • [ ] Switching between general and program orders adjusts the steps correctly
  • [ ] OK is enabled when all steps are complete
  • [ ] closing the modal, closes the modal
  • [ ] programs items are added to the requisition

[wlthomson]

TESTING (WITH PROGRAMS):

Buttons

• [x] Clicking New Requisition button opens the ByProgramModal. PASSED.

Modals

• [x] ByProgramModal modal. PASSED.
  • [x] must select steps in order - program, supplier, period, order type. PASSED.
  • [x] Can back pedal steps, where the progress is adjusted correctly. PASSED.
  • [x] Only order types which are defined for a program are displayed. PASSED.
  • [x] Only periods for the order type defined are displayed. PASSED.
  • [x] Order types, when being selected show the correct details (MOS etc.) PASSED (build includes #1318).
  • [x] Periods, when being selected show the correct details (number of requisitions etc.). PASSED.
  • [x] Switching between general and program orders adjusts the steps correctly. PASSED.
  • [x] OK is enabled when all steps are complete. PASSED.
  • [x] closing the modal, closes the modal. PASSED.
  • [x] programs items are added to the requisition. PASSED.

[wlthomson]

TESTING (WITHOUT PROGRAMS):

Navigation to/from. SUCCESS.

• [x] Can navigate to this page through the Menu Page, Supplier Requisition button. SUCCESS.
• [x] Pressing either the top left back button, or hardware back button navigates to the Menu Page. SUCCESS.
• [x] Navigating to this page, from a Supplier Requisition shows the correctly updated details (i.e. finalising a Supplier Requisition shows that Supplier Requisition as finalised). SUCCESS.

Sync. SUCCESS.

• [x] Supplier Requisition are synced to desktop. SUCCESS.
• [x] Supplier Requisition are synced from desktop. SUCCESS.
• [x] Syncing while on this page correctly updates the table. SUCCESS.

Table. SUCCESS.

• [x] Lists all of this stores Supplier Requisitions. SUCCESS.
• [x] Initial sort is by descending Requisition Number column. SUCCESS.

Row Press. SUCCESS.

• [x] Pressing a row (except for the DELETE column), navigates to the SupplierRequisitionPage. SUCCESS.
• [x] SupplierRequisition navigated to is the one clicked on. SUCCESS.

Filtering. FAILED.

• [ ] Supplier Requisitions are filtered by Supplier name when a search term is entered. FAILED (filtering seems to be done by reqiusition number only).
• [x] Filtering is cleared when the search term is cleared. SUCCESS.

Columns. SUCCESS.

• [x] Requisition Number. SUCCESS.
  • [x] Sortable (and sorts correctly). SUCCESS.
  • [x] New requisitions are correctly increment. SUCCESS.
  • [x] Requisition numbers are correct for each invoice. SUCCESS.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting. SUCCESS.
  • [x] NOT editable. SUCCESS.
  • [x] Requisition numbers are re-used (delete a Requisition, create a new one, should reuse the number). SUCCESS.
  • [x] Left aligned. SUCCESS.
• [x] Supplier. SUCCESS.
  • [x] Sortable (and sorts correctly). SUCCESS.
  • [x Supplier names are correctly listed for every Supplier Requisition. SUCCESS.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting. SUCCESS.
  • [x] NOT editable. SUCCESS.
  • [x] Text overflow handled (Create a Supplier name that is very long). SUCCESS.
  • [x] Left aligned. SUCCESS.
• [x] Entered Date. SUCCESS.
  • [x] Sortable (and sorts correctly). SUCCESS.
  • [x] Shows the correct date an invoice was created. SUCCESS.
  • [x] Dates are in the form [ DayOfWeek Month DateOfMonth Year - DDD MMM MM YYYY ]. SUCCESS.
  • [x] Status' are correctly updated. SUCCESS.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting. SUCCESS.
  • [x] Left aligned. SUCCESS.
• [x] Number Of Items. SUCCESS.
  • [x] Sortable (and sorts correctly). SUCCESS.
  • [x] Shows the correct number of items in the Supplier Requisition. SUCCESS.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting. SUCCESS.
  • [x] Right aligned. SUCCESS.
  • [x] Number of items is correctly updated (when navigating back from a Supplier Requisition). SUCCESS.
• [x] Status. SUCCESS.
  • [x] Sortable (and sorts correctly). SUCCESS.
  • [x] Shows the correct status for an invoice. SUCCESS.
  • [x] Status' should be In Progress or Finalised. SUCCESS.
  • [x] Status' are correctly updated. SUCCESS.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting. SUCCESS.
  • [x] Left aligned. SUCCESS.
• [x] Delete. FAILED.
  • [x] NOT sortable. SUCCESS.
  • [x] NOT editable. SUCCESS.
  • [ ] Finalised invoices are not selectable. FAILED (can "delete" finalised requisitions, although the requisitions do not seem to be removed).
  • [x] Finalised rows indicate they are not selectable. SUCCESS.
  • [x] Rows not finalised are selectable. SUCCESS.
  • [x] Multiple rows are selectable. SUCCESS.
  • [x] Selecting a row opens a confirmation dialog at the bottom of the page. SUCCESS.
  • [x] Unselecting a row closes the confirmation dialog at the bottom of the page. SUCCESS.
  • [x] Confirming the confirmation dialog deletes the Supplier Requisitions. SUCCESS.
  • [x] Cancelling the confirmation dialog removes the current selection and closes the confirmation dialog. SUCCESS.
  • [x] Finalised invoices are not selectable. SUCCESS.

Buttons. SUCCESS.

• [x] Clicking New Requisition button opens a Select a supplier modal. SUCCESS.

  Modals

• [ ] New Requisition Modal. FAILED.
  • [ ] Title is Search for the supplier. FAILED (title is "Select a supplier").
  • [x] Options to select are names records that are: VISIBLE, a SUPPLIER, not THIS store and a STORE type. SUCCESS.
  • [x] Search Bar is auto focused on opening. SUCCESS.
  • [x] Closing the modal, closes the modal. SUCCESS.
  • [x] Filtering the list, filters by supplier name. SUCCESS.
  • [x] Clearing the search term clears filtering. SUCCESS.
  • [x] Clicking a customer creates a new Supplier Requisition and navigates to a SupplierRequisitionPage with the newly created Supplier Requisition open. SUCCESS.

[josh-griffin]

Title is Search for the supplier. FAILED (title is "Select a supplier").

Sorry :(

The row issue is fixed in #1327

[josh-griffin]

NAVIGATION

• [x] Can navigate to this page through the Menu Page, Supplier Requisition button.
• [x] Pressing either the top left back button, or hardware back button navigates to the Menu Page
• [x] Navigating to this page, from a Supplier Requisition shows the correctly updated details [ finalise or add items to a Supplier Requisition - navigating back shows that Supplier Requisition as finalised or the increase in items)

SYNC

• [x] Supplier Requisition are synced to desktop
• [x] Supplier Requisition are synced from desktop

Table

• [x] Lists all of this stores Supplier Requisitions [matching internal orders list inn desktop]
• [x] Initial sort is by descending Requisition Number column.

Row Press

• [x] Pressing a row (except for the DELETE column), navigates to the SupplierRequisitionPage
• [x] SupplierRequisition navigated to is the one clicked on

Filtering

• [x] Supplier Requisitions are filtered by Requisition Number when a search term is entered.
• [x] Filtering is cleared when the search term is cleared [by backspacing or pressing the X].

Columns

• [x] Requisition Number
  • [x] Sortable (and sorts correctly).
  • [x] New requisitions are correctly incremented [Customer and Supplier requisitions SHARE numbers.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Cells are NOT editable.
  • [x] Left aligned
• [x] Supplier
  • [x] Sortable (and sorts correctly).
  • [x] Supplier names are correctly listed for every Supplier Requisition.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Cells NOT editable
  • [x] Text overflow handled (Create a Supplier name that is very long)
  • [x] Left aligned
• [x] Entered Date [Difficult if you don't already have multiple in your data file. Clicking the sort button should be sufficient]
  • [x] Sortable (and sorts correctly).
  • [x] Shows the correct date an invoice was created.
  • [x] Dates are in the form [ DayOfWeek Month DateOfMonth Year - DDD MMM MM YYYY ]
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Left aligned
• [x] Number Of Items
  • [x] Sortable (and sorts correctly).
  • [x] Shows the correct number of items in the Supplier Requisition
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Right aligned
  • [x] Number of items is correctly updated (when navigating back from a Supplier Requisition)
• [x] Status
  • [x] Sortable (and sorts correctly). [This is redundant as of 18/10/19 - might be removed! ]
  • [x] Shows the correct status for an invoice
  • [x] Status' should be In Progress or Finalised [or equivalent per language].
  • [x] Status' are correctly updated.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Left aligned
• [x] Delete
  • [x] NOT a sortable column
  • [x] Cells NOT editable
  • [x] Finalised invoices are not selectable
  • [x] Finalised rows indicate they are not selectable
  • [x] Rows not finalised are selectable
  • [x] Multiple rows are selectable
  • [x] Selecting a row opens a confirmation dialog at the bottom of the page.
  • [x] Unselecting all rows closes the confirmation dialog at the bottom of the page.
  • [x] Confirming the confirmation dialog deletes the Supplier Requisitions
  • [x] Cancelling the confirmation dialog removes the current selection and closes the confirmation dialog
  • [x] Finalised invoices are not selectable

Buttons

• [x] Clicking New Requisition button opens a Select a supplier modal

  Modals

• [x] New Requisition Modal
  • [x] Title is Search for the supplier
  • [x] Options to select are names records that are: VISIBLE, a SUPPLIER, not THIS store and a STORE type.
  • [x] Search Bar is auto focused on opening
  • [x] Closing the modal, closes the modal
  • [x] Filtering the list, filters by supplier name.
  • [x] Clearing the search term clears filtering
  • [x] Clicking a customer creates a new Supplier Requisition and navigates to a SupplierRequisitionPage with the newly created Supplier Requisition open.

WITH PROGRAMS

Having a program means, having a master list which is a program, which has a storeTag matching a tag for this store

Buttons

• [x] Clicking New Requisition button opens the ByProgramModal

Modals

• [x] ByProgramModal modal
  • [x] must select steps in order - program, supplier, period, order type.
  • [x] Can back pedal steps, where the progress is adjusted correctly
  • [x] Only order types which are defined for a program are displayed
  • [x] Only periods for the order type defined are displayed
  • [x] Order types, when being selected show the correct details (MOS etc.)
  • [x] Periods, when being selected show the correct details (number of requisitions etc.)
  • [x] Switching between general and program orders adjusts the steps correctly
  • [x] OK is enabled when all steps are complete
  • [x] closing the modal, closes the modal
  • [x] programs items are added to the requisition

[diegoevangelisti]

NAVIGATION

• [x] Can navigate to this page through the Menu Page, Supplier Requisition button.
• [x] Pressing either the top left back button, or hardware back button navigates to the Menu Page
• [x] Navigating to this page, from a Supplier Requisition shows the correctly updated details [ finalise or add items to a Supplier Requisition - navigating back shows that Supplier Requisition as finalised or the increase in items)

SYNC

• [x] Supplier Requisition are synced to desktop
• [x] Supplier Requisition are synced from desktop

Table

• [x] Lists all of this stores Supplier Requisitions [matching internal orders list inn desktop]
• [x] Initial sort is by descending Requisition Number column.

Row Press

• [x] Pressing a row (except for the DELETE column), navigates to the SupplierRequisitionPage
• [x] SupplierRequisition navigated to is the one clicked on

Filtering

• [x] Supplier Requisitions are filtered by Requisition Number when a search term is entered.
• [x] Filtering is cleared when the search term is cleared [by backspacing or pressing the X].

Columns

• [x] Requisition Number
  • [x] Sortable (and sorts correctly).
  • [x] New requisitions are correctly incremented [Customer and Supplier requisitions SHARE numbers.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Cells are NOT editable.
  • [x] Left aligned
• [x] Supplier
  • [x] Sortable (and sorts correctly).
  • [x] Supplier names are correctly listed for every Supplier Requisition.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Cells NOT editable
  • [x] Text overflow handled (Create a Supplier name that is very long)
  • [x] Left aligned
• [x] Entered Date [Difficult if you don't already have multiple in your data file. Clicking the sort button should be sufficient]
  • [x] Sortable (and sorts correctly).
  • [x] Shows the correct date an invoice was created.
  • [x] Dates are in the form [ DayOfWeek Month DateOfMonth Year - DDD MMM DD YYYY ]
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Left aligned
• [x] Number Of Items
  • [x] Sortable (and sorts correctly).
  • [x] Shows the correct number of items in the Supplier Requisition
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Right aligned
  • [x] Number of items is correctly updated (when navigating back from a Supplier Requisition)
• [x] Status
  • [x] Shows the correct status for an invoice
  • [x] Status' should be In Progress or Finalised [or equivalent per language].
  • [x] Status' are correctly updated.
  • [x] Left aligned
• [x] Delete
  • [x] NOT a sortable column
  • [x] Cells NOT editable
  • [x] Finalised invoices are not selectable
  • [x] Finalised rows indicate they are not selectable
  • [x] Rows not finalised are selectable
  • [x] Multiple rows are selectable
  • [x] Selecting a row opens a confirmation dialog at the bottom of the page.
  • [x] Unselecting all rows closes the confirmation dialog at the bottom of the page.
  • [x] Confirming the confirmation dialog deletes the Supplier Requisitions
  • [x] Cancelling the confirmation dialog removes the current selection and closes the confirmation dialog
  • [x] Finalised invoices are not selectable

Buttons

• [x] Clicking New Requisition button opens a Select a supplier modal

  Modals

• [x] New Requisition Modal (Fail) Title is Search for the supplier --> TItle is: Select a supplier and for Search bar placeholder: Start typing to search
  • [x] Options to select are names records that are: VISIBLE, a SUPPLIER, not THIS store and a STORE type.
  • [x] Search Bar is auto focused on opening
  • [x] Closing the modal, closes the modal
  • [x] Filtering the list, filters by supplier name.
  • [x] Clearing the search term clears filtering
  • [x] Clicking a customer creates a new Supplier Requisition and navigates to a SupplierRequisitionPage with the newly created Supplier Requisition open.

WITH PROGRAMS

Having a program means, having a master list which is a program, which has a storeTag matching a tag for this store

Buttons

• [x] Clicking New Requisition button opens the ByProgramModal

Modals

• [x] ByProgramModal modal
  • [x] must select steps in order - program, supplier, period, order type.
  • [x] Can back pedal steps, where the progress is adjusted correctly
  • [x] Only order types which are defined for a program are displayed
  • [x] Only periods for the order type defined are displayed
  • [x] Order types, when being selected show the correct details (MOS etc.)
  • [x] Periods, when being selected show the correct details (number of requisitions etc.)
  • [x] Switching between general and program orders adjusts the steps correctly
  • [x] OK is enabled when all steps are complete
  • [x] closing the modal, closes the modal
  • [x] programs items are added to the requisition

Test completed. Just one minor detail in New Requisition modal (see above).

[josh-griffin]

Title is Search for the supplier --> TItle is: Select a supplier...

Updated the top comment. Great work thanks so much!

[CarlosNZ]

TESTING -- COMPLETE

TESTER NOTES:

• Ensure one of the EXTERNAL SUPPLIERS [A [name] which is a FACILITY not a STORE and is a supplier] has a very long name
• If testing both SupplierRequisitionPage and SupplierRequisitionsPage, will be faster to do them both without programs first and then with programs after

Supplier Requisitions Page

NOTE: This page has a customization regarding PROGRAMS (sorry only docs there are at the moment!)

This page should be tested WITH NO PROGRAMS and WITH PROGRAMS. Alterations to the behaviour of this page are listed at the BOTTOM of this list.

NAVIGATION

• [x] Can navigate to this page through the Menu Page, Supplier Requisition button.
• [x] Pressing either the top left back button, or hardware back button navigates to the Menu Page
• [x] Navigating to this page, from a Supplier Requisition shows the correctly updated details [ finalise or add items to a Supplier Requisition - navigating back shows that Supplier Requisition as finalised or the increase in items)

SYNC

• [x] Supplier Requisition are synced to desktop
• [ ] Supplier Requisition are synced from desktop (Can't test because can't connect with data files other than demo_primary.4dd)

Table

• [x] Lists all of this stores Supplier Requisitions [matching internal orders list inn desktop]
• [x] Initial sort is by descending Requisition Number column.

Row Press

• [x] Pressing a row (except for the DELETE column), navigates to the SupplierRequisitionPage
• [x] SupplierRequisition navigated to is the one clicked on

Filtering

• [x] Supplier Requisitions are filtered by Requisition Number when a search term is entered.
• [x] Filtering is cleared when the search term is cleared [by backspacing or pressing the X].

Columns

• [x] Requisition Number
  • [x] Sortable (and sorts correctly).
  • [x] New requisitions are correctly incremented [Customer and Supplier requisitions SHARE numbers.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Cells are NOT editable.
  • [x] Left aligned
• [ ] Supplier
  • [x] Sortable (and sorts correctly).
  • [x] Supplier names are correctly listed for every Supplier Requisition.
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Cells NOT editable
  • [ ] Text overflow handled (Create a Supplier name that is very long)
  • [x] Left aligned
• [ ] Entered Date [Difficult if you don't already have multiple in your data file. Clicking the sort button should be sufficient]
  • [x] Sortable (and sorts correctly).
  • [x] Shows the correct date an invoice was created.
  • [ ] Dates are in the form [ DayOfWeek Month DateOfMonth Year - DDD MMM MM YYYY ]
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Left aligned
• [x] Number Of Items
  • [x] Sortable (and sorts correctly).
  • [x] Shows the correct number of items in the Supplier Requisition
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Right aligned
  • [x] Number of items is correctly updated (when navigating back from a Supplier Requisition)
• [ ] Status Sortable (and sorts correctly). [This is redundant as of 18/10/19 - might be removed! ]
  • [x] Shows the correct status for an invoice
  • [x] Status' should be In Progress or Finalised [or equivalent per language].
  • [x] Status' are correctly updated. Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Left aligned
• [ ] Delete
  • [x] NOT a sortable column
  • [x] Cells NOT editable
  • [x] Finalised invoices are not selectable
  • [x] Finalised rows indicate they are not selectable
  • [x] Rows not finalised are selectable
  • [x] Multiple rows are selectable
  • [x] Selecting a row opens a confirmation dialog at the bottom of the page.
  • [ ] Unselecting all rows closes the confirmation dialog at the bottom of the page.
  • [x] Confirming the confirmation dialog deletes the Supplier Requisitions
  • [x] Cancelling the confirmation dialog removes the current selection and closes the confirmation dialog
  • [x] Finalised invoices are not selectable

Buttons

• [x] Clicking New Requisition button opens a Select a supplier modal

  Modals

• [x] New Requisition Modal
  • [x] Title is Select a supplier
  • [x] Options to select are names records that are: VISIBLE, a SUPPLIER, not THIS store and a STORE type.
  • [x] Search Bar is auto focused on opening
  • [x] Closing the modal, closes the modal
  • [x] Filtering the list, filters by supplier name.
  • [x] Clearing the search term clears filtering
  • [x] Clicking a customer creates a new Supplier Requisition and navigates to a SupplierRequisitionPage with the newly created Supplier Requisition open.

WITH PROGRAMS

Having a program means, having a master list which is a program, which has a storeTag matching a tag for this store

Buttons

• [x] Clicking New Requisition button opens the ByProgramModal

Modals

• [x] ByProgramModal modal
  • [x] must select steps in order - program, supplier, period, order type.
  • [x] Can back pedal steps, where the progress is adjusted correctly
  • [x] Only order types which are defined for a program are displayed
  • [x] Only periods for the order type defined are displayed
  • [x] Order types, when being selected show the correct details (MOS etc.)
  • [x] Periods, when being selected show the correct details (number of requisitions etc.)
  • [x] Switching between general and program orders adjusts the steps correctly
  • [x] OK is enabled when all steps are complete
  • [x] closing the modal, closes the modal
  • [x] programs items are added to the requisition

[CarlosNZ]

NOTE: Same problem when selecting and unselecting as noted here.

[CarlosNZ]

The full list of Stores available in mSupply are not showing up as Supplier options when starting a new Supplier requisition. Should they be, or what's the criteria to get them to be in the list for Supplier requisition suppliers?

[josh-griffin]

@CarlosNZ

I just checked it out - it seems the server is no sending the Name records after initialization - after doing the same as you - after re-initializing I had the new Name record and was able to create requisitions to it. Are you able to confirm?

If that's the case - it seems to be a desktop bug and we we will need to make an issue there

[josh-griffin]

Thanks for testing!

Have created an issue re the row selection here: https://github.com/openmsupply/mobile/issues/2221

[CarlosNZ]

@CarlosNZ

I just checked it out - it seems the server is no sending the Name records after initialization - after doing the same as you - after re-initializing I had the new Name record and was able to create requisitions to it. Are you able to confirm?

If that's the case - it seems to be a desktop bug and we we will need to make an issue there

What exactly do you mean by "re-initializing"?

[josh-griffin]

• initializing - The initial step of entering the server IP, site name and site password and retrieving all the records for that site.

• Re-initializing - doing that again - can only do that by either clearing "App data":

Or by re-installing the app

• The code for "initializing" and "regular syncing" is different, looks like there is a problem with regular syncing

[CarlosNZ]

Yeah, nah, re-installing still isn't seeing all the Stores in the list of suppliers in requisitions. Wondering if there's something different in the new store I created on Desktop?

[josh-griffin]

I have this store now which I can make requisitions to:

My store:

The related Name:

Visibility is set (Actually should be from my mobile store way but I can't be bothered going and getting another screen shot):

I did need to re-initialize to get it to show up though :(

[CarlosNZ]

Ok -- yeah it shows up, but only after re-initialising.

[josh-griffin]

Sweet thanks -

If you don't mind could you create a desktop issue?

[wlthomson]

Updated for v5.0.0.

[diegoevangelisti]

@wlthomson all good, just a minor detail regarding the sorting icons for REQUISITION NUMBER (see my previous comment)

Supplier Requisitions Page

This page should be tested WITH NO PROGRAMS and WITH PROGRAMS. Alterations to the behaviour of this page are listed at the BOTTOM of this list.

NAVIGATION

• [x] Can navigate to this page through the Menu Page, "Supplier Requisition" button
• [x] Pressing either the top left back button, or hardware back button navigates to the Menu Page
• [x] Navigating to this page from a supplier requisition shows the correctly updated details (finalise or add items to a supplier requisition, navigating back shows that supplier requisition as finalised or the increase in items)

SYNC

• [x] Supplier requisitions are synced to desktop
• [x] Supplier requisitions are synced from desktop

Table

• [x] List all supplier requisitions for this store (matches internal orders list in desktop)
• [x] Initial sort is by requisition number in descending order

Row Press

• [x] Pressing a row (except for the "DELETE" column), navigates to the SupplierRequisitionPage
• [x] The supplier requisition navigated to is the row that was pressed

Filtering

• [x] Supplier requisitions are filtered by requisition number when a search term is entered
• [x] Filtering is cleared when the search term is cleared [by backspacing or pressing the X].

Columns

• [x] REQUISITION NUMBER
  • [x] Sortable (and sorts correctly)
  • [x] New requisitions are correctly incremented (customer and supplier requisitions share numbers)
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting
  • [x] Cells are NOT editable
  • [x] Left aligned
• [x] SUPPLIER
  • [x] Sortable (and sorts correctly)
  • [x] Supplier names are correctly listed for every supplier requisition
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Cells NOT editable
  • [x] Text overflow handled (create a Supplier name that is very long)
  • [x] Left aligned
• [x] PROGRAM (NOTE: only displays if at least one requisition is associated with a program)
  • [x] Does not display if no requisitions are associated with a program (includes current AND past requisitions)
  • [x] Displays if at least one requisition is associated with a program (includes current AND past requisitions)
  • [x] Sortable (and sorts correctly)
  • [x] Programs are listed correctly for every customer requisition ("N/A" if requisition has no program)
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting
  • [x] Cells are NOT editable
  • [x] Text overflow handled (create a program name that is very long)
  • [x] Left aligned
• [x] ITEMS
  • [x] Sortable (and sorts correctly)
  • [x] Shows the correct number of items in the supplier requisition
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Right aligned
  • [x] Number of items is correctly updated (when navigating back from a supplier requisition)
• [x] ENTERED DATE
  • [x] Sortable (and sorts correctly): this might be difficult if the data file is new or there are no old records, so clicking the sort button and having the icon change is sufficient
  • [x] Shows the correct date an invoice was created
  • [x] Dates are in the form: WeekDay Month Year, e.g. 17 May 2008
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting
  • [x] Left aligned
  • [x] Cells are NOT editable
• [x] STATUS
  • [x] NOT sortable
  • [x] Shows the correct status for an invoice
  • [x] Status is one of: "In Progress" or "Finalised" (or localised equivalents)
  • [ ] Sorting icon updates correctly to indicate ascending/descending and no sorting There is no sorting icons -it makes sense-
  • [x] Left aligned
  • [x] Cells are NOT editable
• [x] Remove
  • [x] NOT a sortable column
  • [x] Cells NOT editable
  • [x] Finalised invoices are not selectable
  • [x] Finalised rows indicate they are not selectable
  • [x] Rows not finalised are selectable
  • [x] Multiple rows are selectable
  • [x] Selecting a row opens a confirmation dialog at the bottom of the page
  • [x] Unselecting all rows closes the confirmation dialog at the bottom of the page
  • [x] Confirming the confirmation dialog deletes the supplier requisitions
  • [x] Cancelling the confirmation dialog removes the current selection and closes the confirmation dialog
  • [x] Finalised invoices are not selectable

Buttons

• [x] "New Requisition"
  • [x] Button is displayed.
  • [x] On press, button opens "Select a supplier" modal

Modals

• [x] New Requisition Modal
  • [x] Title is "Select a supplier"
  • [x] Options to select are names records that are: VISIBLE, a SUPPLIER, not THIS store and a STORE type
  • [x] Search Bar is auto focused on opening
  • [x] Closing the modal, closes the modal
  • [x] Filtering the list, filters by supplier name.
  • [x] Clearing the search term clears filtering
  • [x] Clicking a customer creates a new supplier requisition and navigates to a SupplierRequisitionPage with the newly created supplier requisition open

WITH PROGRAMS

Note: Having a program: Having a master list which is a program related to the store with a store tag matching a tag in this stores tag

Buttons

• [x] "New Requisition"
  • [x] Button is displayed
  • [x] On press, button opens ByProgramModal

Modals

• [x] ByProgramModal
  • [ ] Must select steps in order: program, supplier, period, order type Note for @wlthomson => order is: program, supplier, order type, period
  • [x] Can back pedal steps, where the progress is adjusted correctly
  • [x] Only order types which are defined for a program are displayed
  • [x] Only periods for the order type defined are displayed
  • [x] Order types, when being selected show the correct details (MOS etc.)
  • [x] Periods, when being selected show the correct details (number of requisitions etc.)
  • [x] Switching between general and program orders adjusts the steps correctly
  • [x] OK is enabled when all steps are complete
  • [x] closing the modal, closes the modal
  • [x] programs items are added to the requisition

[diegoevangelisti]

@wlthomson I wonder if there is another issue related with this one (before I create mine). The sorting arrows are hidden for REQUISITION NUMBER (see example below):

[wlthomson]

@diegoevangelisti Good spot, looks like a column sizing issue. Could you make an issue?

[wlthomson]

Note for @wlthomson => order is: program, supplier, order type, period

Nice one. Updated!

[diegoevangelisti]

@diegoevangelisti Good spot, looks like a column sizing issue. Could you make an issue?

Sure @wlthomson, I'll create one now! UPDATED: #2804

[wlthomson]

@diegoevangelisti Thanks for testing! Moving to done!

[josh-griffin]

TESTING

This is an issue for testing SupplierRequisitionsPage.

Please copy and paste this list of tests and post your results in a comment in this issue.

TESTER NOTES:

• Ensure one of the EXTERNAL SUPPLIERS (Name record which is a facility, NOT a store, and is a supplier) has a very long name
• If testing both SupplierRequisitionPage and SupplierRequisitionsPage, will be faster to do them both without programs first and then with programs after

Supplier Requisitions Page

This page should be tested WITH NO PROGRAMS and WITH PROGRAMS. Alterations to the behaviour of this page are listed at the BOTTOM of this list.

NAVIGATION

• [x] Can navigate to this page through the Menu Page, "Supplier Requisition" button
• [x] Pressing either the top left back button, or hardware back button navigates to the Menu Page
• [x] Navigating to this page from a supplier requisition shows the correctly updated details (finalise or add items to a supplier requisition, navigating back shows that supplier requisition as finalised or the increase in items)

SYNC

• [x] Supplier requisitions are synced to desktop
• [x] Supplier requisitions are synced from desktop

Table

• [x] List all supplier requisitions for this store (matches internal orders list in desktop)
• [x] Initial sort is by requisition number in descending order

Row Press

• [x] Pressing a row (except for the "DELETE" column), navigates to the SupplierRequisitionPage
• [x] The supplier requisition navigated to is the row that was pressed

Filtering

• [x] Supplier requisitions are filtered by requisition number when a search term is entered
• [x] Filtering is cleared when the search term is cleared [by backspacing or pressing the X].

Columns

• [x] REQUISITION NUMBER
  • [x] Sortable (and sorts correctly)
  • [x] New requisitions are correctly incremented (customer and supplier requisitions share numbers)
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting
  • [x] Cells are NOT editable
  • [x] Left aligned
• [x] SUPPLIER
  • [x] Sortable (and sorts correctly)
  • [x] Supplier names are correctly listed for every supplier requisition
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Cells NOT editable
  • [x] Text overflow handled (create a Supplier name that is very long)
  • [x] Left aligned
• [ ] PROGRAM (NOTE: only displays if at least one requisition is associated with a program)
  • [ ] Does not display if no requisitions are associated with a program (includes current AND past requisitions)
  • [ ] Displays if at least one requisition is associated with a program (includes current AND past requisitions)
  • [ ] Sortable (and sorts correctly)
  • [ ] Programs are listed correctly for every customer requisition ("N/A" if requisition has no program)
  • [ ] Sorting icon updates correctly to indicate ascending/descending and no sorting
  • [ ] Cells are NOT editable
  • [ ] Text overflow handled (create a program name that is very long)
  • [ ] Left aligned
• [x] ITEMS
  • [x] Sortable (and sorts correctly)
  • [x] Shows the correct number of items in the supplier requisition
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting.
  • [x] Right aligned
  • [x] Number of items is correctly updated (when navigating back from a supplier requisition)
• [x] ENTERED DATE
  • [x] Sortable (and sorts correctly): this might be difficult if the data file is new or there are no old records, so clicking the sort button and having the icon change is sufficient
  • [x] Shows the correct date an invoice was created
  • [x] Dates are in the form: WeekDay Month Year, e.g. 17 May 2008
  • [x] Sorting icon updates correctly to indicate ascending/descending and no sorting
  • [x] Left aligned
  • [x] Cells are NOT editable
• [x] STATUS
  • [x] NOT sortable
  • [x] Shows the correct status for an invoice
  • [x] Status is one of: "In Progress" or "Finalised" (or localised equivalents)
  • [x] Left aligned
  • [x] Cells are NOT editable
• [ ] Delete
  • [x] NOT a sortable column
  • [x] Cells NOT editable
  • [x] Finalised invoices are not selectable
  • [x] Finalised rows indicate they are not selectable
  • [x] Rows not finalised are selectable
  • [x] Multiple rows are selectable
  • [x] Selecting a row opens a confirmation dialog at the bottom of the page
  • [x] Unselecting all rows closes the confirmation dialog at the bottom of the page
  • [x] Confirming the confirmation dialog deletes the supplier requisitions
  • [x] Cancelling the confirmation dialog removes the current selection and closes the confirmation dialog
  • [x] Finalised invoices are not selectable

Buttons

• [x] "New Requisition"
  • [x] Button is displayed.
  • [x] On press, button opens "Select a supplier" modal

Modals

• [x] New Requisition Modal
  • [x] Title is "Select a supplier"
  • [x] Options to select are names records that are: VISIBLE, a SUPPLIER, not THIS store and a STORE type
  • [x] Search Bar is auto focused on opening
  • [x] Closing the modal, closes the modal
  • [x] Filtering the list, filters by supplier name.
  • [x] Clearing the search term clears filtering
  • [x] Clicking a customer creates a new supplier requisition and navigates to a SupplierRequisitionPage with the newly created supplier requisition open

WITH PROGRAMS

Note: Having a program: Having a master list which is a program related to the store with a store tag matching a tag in this stores tag

Buttons

• [x] "New Requisition"
  • [x] Button is displayed
  • [x] On press, button opens ByProgramModal

Modals

• [x] ByProgramModal
  • [x] Must select steps in order: program, supplier, order type, period
  • [x] Can back pedal steps, where the progress is adjusted correctly
  • [x] Only order types which are defined for a program are displayed
  • [x] Only periods for the order type defined are displayed
  • [x] Order types, when being selected show the correct details (MOS etc.)
  • [x] Periods, when being selected show the correct details (number of requisitions etc.)
  • [x] Switching between general and program orders adjusts the steps correctly
  • [x] OK is enabled when all steps are complete
  • [x] closing the modal, closes the modal
  • [x] programs items are added to the requisition