msupply-foundation / mobile

Open source mobile app for medical inventory control
http://msupply.org.nz/mobile
Other
43 stars 27 forks source link

TESTING: Vaccine Module #2913

Closed josh-griffin closed 3 years ago

josh-griffin commented 4 years ago

This is an issue for testing Vaccines Module.

Please copy and paste this list of tests and post your results in a comment in this issue.

[Provsional public docs: https://docs.google.com/document/d/1MD17DWP5BJYVh7KuHsdexHUhSMBB0JWg8TeBAR4_gBY/edit#heading=h.ktu9skw3ggj0

Supplier Invoice

New Columns

Customer Invoice

New Columns


COLD CHAIN FUNCTIONALITY

SETUP TIPS:

ADD A NEW SENSOR:

STEP ONE:

STEP TWO:

STEP THREE:

EDIT A NEW SENSOR:

TABLET PERMISSIONS

diegoevangelisti commented 4 years ago

@joshxg It looks really good overall, it doesn't crash at all - believe me I tried. As I mentioned before, great job here 🙌🏻

I would like to add some notes that I believe are important:

Screen Shot 2020-06-23 at 4 00 57 PM

Supplier Invoice

New Columns

Main page

Vaccines page

Vaccines Admin

Sensor

ArpitaSussol commented 3 years ago

Tested in V7.0.0-rc10


COLD CHAIN FUNCTIONALITY


Progress bar keeps on loading with no message.

ADD A NEW SENSOR:

STEP ONE:

STEP TWO:

STEP THREE:

EDIT A NEW SENSOR:

TABLET PERMISSIONS

Supplier Invoice

New Columns

Customer Invoice

New Columns

kat-ms commented 3 years ago

Started testing against the template (just to start being a bit more methodical - have previously just been doing things a little all over the place).

Will keep updated with progress.

Supplier Invoice

New Columns

Customer Invoice

New Columns


COLD CHAIN FUNCTIONALITY


ADD A NEW SENSOR:

STEP ONE:

STEP TWO:

STEP THREE:

EDIT A NEW SENSOR:

TABLET PERMISSIONS

josh-griffin commented 3 years ago

@ArpitaSussol @katherine-sussol is this all done?

kat-ms commented 3 years ago

Testing against the template is done on my end and mostly looking good - just a few observations:

josh-griffin commented 3 years ago

I can't seem to see any of the expected item.restrictedLocationType behaviour. When setting a restricted location in Desktop all the locations setup via sensors are showing up in the location modal - not sure if this is intended/bad/me doing something wrong.

Ahh sorry- I thought I removed this 🤷 This restricted location type behaviour was removed

This test case (stocktake VVM status) I think is technically a pass but the description doesn't match ;) - as the column doesn't show up at all

This was recently changed also to not show rather than be disabled

wlthomson commented 3 years ago

@katherine-sussol If we remove the out-of-date tests (which we probably should!), does that leave us with anything else for this template?

kat-ms commented 3 years ago

I do worry about hidden 🐛 that might not be picked up by testing against the template (a lot of the high severity ones detected lately have required testing beyond what's here) but there is nothing outstanding from my end for this template 👍 .

Not sure but @ArpitaSussol may have some things to still be addressed?

kat-ms commented 3 years ago

Have made some minor updates to the tests to reflect the correct expected behaviour

ArpitaSussol commented 3 years ago

@ArpitaSussol @katherine-sussol is this all done?

Except the issues addressed by @katherine-sussol and me, it looks good overall. Not seeing any major blocker issue right now. So its good to go from my side :)

josh-griffin commented 3 years ago

Thanks @ArpitaSussol