Closed josh-griffin closed 3 years ago
@joshxg It looks really good overall, it doesn't crash at all - believe me I tried. As I mentioned before, great job here 🙌🏻
I would like to add some notes that I believe are important:
cartesianInterpolations
selected option is resulting on a strange graph - tried with monotoneX
instead and it looked much betteritems.restrictedLocationType
, IMO the user should be a different (clearer) error message.item.restrictedLocationType
item.restrictedLocationType
is null, all locations are listed.item.restrictedLocationType
-PASS-item.restrictedLocationType
is null, all locations are listed. -PASS-Tested in V7.0.0-rc10
Vaccine Module Page:
[ ] If there are no ACTIVE sensors, a message is displayed. #3733
Progress bar keeps on loading with no message.
[x] Lists all currently ACTIVE sensors.
[x] Download button works correctly
[x] Blink button works correctly
[x] Settings button works correctly
[x] Clicking a row navigates to the fridge detail page for that sensor
Fridge Detail Page:
[x] The bar chart is correct
[x] The line chart is correct
[x] The sensor status is correct [ Rectangle on the right of the chart which shows the current temperature]
[x] Circle
[x] Date picker is correct
[x] Breach card
[x] Header
ADD A NEW SENSOR:
STEP ONE:
BLINK
will cause the sensor to blink its LEDSTEP TWO:
STEP THREE:
[x] CONNECT will load a SPINNER and send bluetooth commands to the sensor
[x] The sensor should be saved to the database correctly:
[x] The sensor NAME/MAC address/log interval/log delay is all correctly set in the database (Can sync and see on desktop) #3732 In Database, Sensor's Log interval is showing 0 every time although its been updated each time in Mobile.
[x] There is a related LOCATION record which has the CODE which was entered
[x] There are FOUR x temperature_breach_configuration records which have the temperature and durations set.
EDIT A NEW SENSOR:
isActive
set to FALSEisActive
set to TRUEisActive
field set to FALSETABLET PERMISSIONS
item.restrictedLocationType
item.restrictedLocationType
is null, all locations are listed.Started testing against the template (just to start being a bit more methodical - have previously just been doing things a little all over the place).
Will keep updated with progress.
item.restrictedLocationType
item.restrictedLocationType
is null, all locations are listed.Vaccine Module Page:
[x] If there are no ACTIVE sensors, a message is displayed
[x] Lists all currently ACTIVE sensors.
[x] Download button works correctly
[x] Blink button works correctly
[x] Settings button works correctly
[x] Clicking a row navigates to the fridge detail page for that sensor
Fridge Detail Page:
[x] The bar chart is correct
[x] The line chart is correct
[x] The sensor status is correct [ Rectangle on the right of the chart which shows the current temperature]
[x] Circle
[x] Date picker is correct
[x] Breach card
[x] Header
ADD A NEW SENSOR:
STEP ONE:
BLINK
will cause the sensor to blink its LEDSTEP TWO:
STEP THREE:
EDIT A NEW SENSOR:
isActive
set to FALSEisActive
set to TRUEisActive
field set to FALSETABLET PERMISSIONS
@ArpitaSussol @katherine-sussol is this all done?
Testing against the template is done on my end and mostly looking good - just a few observations:
I can't seem to see any of the expected item.restrictedLocationType
behaviour. When setting a restricted location in Desktop all the locations setup via sensors are showing up in the location modal - not sure if this is intended/bad/me doing something wrong.
This test case (stocktake VVM status) I think is technically a pass but the description doesn't match ;) - as the column doesn't show up at all
These are not checked because of concerns/observations #3706 here (although issue is line graph specific it could be related?)
This is unchecked although probably intended behaviour is a pass - if in cold breach and low battery the rectangle is blue but still flashes the low battery icon
This is in principle a pass but there's a case when it's paused that it just displays 'PAUSED' rather than the most recent attempt to download
I can't seem to see any of the expected item.restrictedLocationType behaviour. When setting a restricted location in Desktop all the locations setup via sensors are showing up in the location modal - not sure if this is intended/bad/me doing something wrong.
Ahh sorry- I thought I removed this 🤷 This restricted location type behaviour was removed
This test case (stocktake VVM status) I think is technically a pass but the description doesn't match ;) - as the column doesn't show up at all
This was recently changed also to not show rather than be disabled
@katherine-sussol If we remove the out-of-date tests (which we probably should!), does that leave us with anything else for this template?
I do worry about hidden 🐛 that might not be picked up by testing against the template (a lot of the high severity ones detected lately have required testing beyond what's here) but there is nothing outstanding from my end for this template 👍 .
Not sure but @ArpitaSussol may have some things to still be addressed?
Have made some minor updates to the tests to reflect the correct expected behaviour
item.restrictedLocationType
tests@ArpitaSussol @katherine-sussol is this all done?
Except the issues addressed by @katherine-sussol and me, it looks good overall. Not seeing any major blocker issue right now. So its good to go from my side :)
Thanks @ArpitaSussol
This is an issue for testing Vaccines Module.
Please copy and paste this list of tests and post your results in a comment in this issue.
[Provsional public docs: https://docs.google.com/document/d/1MD17DWP5BJYVh7KuHsdexHUhSMBB0JWg8TeBAR4_gBY/edit#heading=h.ktu9skw3ggj0
Supplier Invoice
New Columns
Customer Invoice
New Columns
Supplier Requisition
Row
Stocktake
New columns on batch edit
COLD CHAIN FUNCTIONALITY
SETUP TIPS:
Can use BlueMaestro App to validate temperature/sensor settings - ensure Temperature Calibration is set to 0 degrees celsius, this will make the comparison easier!
When testing, it's best to only connect one mSupply app (either mSupply mobile or mSupply ColdChain) at a time to a sensor (unless specifically investigating multi app support), as using more than one will cause conflicts between the logging interval settings
Vaccine Module Page:
[ ] If there are no ACTIVE sensors, a message is displayed
[ ] Lists all currently ACTIVE sensors.
[ ] Download button works correctly
[ ] Blink button works correctly
[ ] Settings button works correctly
[ ] Clicking a row navigates to the fridge detail page for that sensor
Fridge Detail Page:
[ ] The bar chart is correct
[ ] The line chart is correct
[ ] The sensor status is correct [ Rectangle on the right of the chart which shows the current temperature]
[ ] Circle
[ ] Date picker is correct
[ ] Breach card
[ ] Header
ADD A NEW SENSOR:
STEP ONE:
BLINK
will cause the sensor to blink its LEDSTEP TWO:
STEP THREE:
EDIT A NEW SENSOR:
isActive
set to FALSEisActive
set to TRUEisActive
field set to FALSETABLET PERMISSIONS