msupply-foundation / mobile

Open source mobile app for medical inventory control
http://msupply.org.nz/mobile
Other
43 stars 27 forks source link

Replace React Native Modal Box #3213

Open josh-griffin opened 3 years ago

josh-griffin commented 3 years ago

The suggestion

We use the package react-native-modalbox. It has some issues - in particular that the component is both controlled and uncontrolled which causes glitchy behaviour.

It is also unmainted with 130+ issues and people requesting forks etc.

Why?

Oh.. But I put this in the suggestion.

Describe alternatives you've considered

"Dealing" with it.

Additional context

I can't find a different component which will do what we want. In particular, we use this modal as a 'popup' at the bottom of the screen which has 'click-through' - so, it's not really a modal per se (Did I use that right?).

Options:

josh-griffin commented 3 years ago

Have investigated this a bit more and the internal state issue can be fixed by replacing the modal box but the jankiness of the animations are a bit more difficult, we really need to run the animation on the UI thread, but that's not possible unless we enable hermes