msupply-foundation / mobile

Open source mobile app for medical inventory control
http://msupply.org.nz/mobile
Other
43 stars 27 forks source link

Comments on requisition lines #411

Open andrew-d-uk opened 7 years ago

andrew-d-uk commented 7 years ago

When making requisitions, it is good practice for stores to comment why they have requested the amount they have for a particular item, and not the mSupply suggested quantity for example - this may be because they are expanding or expect a higher monthly consumption due to seasonal fluctuations. As mSupply mobile users, the only way to get around this would be to make such comments in an email, which would over-complicate the process when ordering 200+ items! A comment field already exists in requisition_line and in the mSupply desktop requisiton viewer, but does not appear in mSupply mobile (presumably to avoid cluttering).

Would it be possible to add a field to mSupply mobile requisition page which shows whether there is a comment. (It should not contain the comment text as it would not fit!) It could be clicked to add or edit a comment.

Chris-Petty commented 7 years ago

Hi Andrew,

I hear you on this one. You're right about it not being included in order to keep things simple and uncluttered, but I hear you on the need for it. Adding a small column with a button taking to a comment modal (similar to the comment editor for the requisition as a whole, above the table), would be the best approach I'd expect.

Unfortunately real estate for columns when viewing a requisition is already pushed to the limit on our smallest supported resolution. There is some wiggle room making the column titles be over 2 lines, though.

In the mean time I believe the idea has been to use the requisition comment to note that you are getting extra of various things because of what ever reason. This falls down if every other line has a different reason.

josh-griffin commented 5 years ago

@Chris-Petty

Do we still intend to implement this feature?

Chris-Petty commented 5 years ago

Yes. Row modal similar to stocktake reasons would serve this.