msupply-foundation / mobile

Open source mobile app for medical inventory control
http://msupply.org.nz/mobile
Other
43 stars 27 forks source link

Some info are not displayed on the customer invoice of a vaccination synced to the server #4742

Closed alainsussol closed 2 years ago

alainsussol commented 2 years ago

Describe the bug

The name notes description are not displayed in an invoice of a vaccination. Also the name of the vaccinator is displayed as empty while there was a vaccinator but maybe the vaccinator is not consider the same as a Prescriber

image

image

This patient has name notes

image

To reproduce

Steps to reproduce the behaviour:

  1. Go to mobile create a vaccination
  2. Go through the vaccination process. Add a vaccinator
  3. Sync and check the customer invoice on the server
  4. See error

Expected behaviour

I suppose the name note description should be displayed as well as the vaccinator name as the prescriber ?

Proposed Solution

Leave if you don't know how to fix/implement. Edit this issue description and explain here if you know the best path of implementing the fix within the codebase.

Version and device info

Additional context

Add any other context about the problem here.

kat-ms commented 2 years ago

A little bit tricky as vaccinators ('MedicineAdministrator' table in mobile / 'medicine_administrator' in Desktop) are a separate entity from prescribers ('Prescribers' in mobile / 'clinician' in Desktop) and they are generally different groups of people (i.e. prescribers are qualified to authorise prescriptions whereas vaccinators have possibly only been trained how to jab someone with a needle). I'd even argue it's a little odd to have vaccinations show up as 'prescriptions' 😆.

I'd classify it as a pre-existing issue/unaddressed debt from mobile 8.0.0/vaccine dispensing release - I think it could be possible to enhance in Desktop to show 'vaccinator' instead of 'prescriber' for vaccinations... although am unsure on the priority given the unlikelihood of vaccine dispensing being extended beyond Tonga/Kiribati. @DhanyaHerath can I nag you for your thoughts on whether this is worth prioritising/creating a Desktop issue for or not?

I think it is a similar case with the name_note records, all of the vaccine-related data is stored in name_note.data whereas I think the UI in desktop is looking at the name_note.note field.

DhanyaHerath commented 2 years ago

@katherine-sussol I think you're 100% correct on those points - prescriptions and vaccinations are different; it would be possible to add "Vaccinator" to desktop UI, and the name_notes are not displayed well (I could have sworn we have an issue for that already but I can't see it now...).

However, I don't think we will prioritise this for desktop and I'm not sure whether it's even worth making an issue for :( , firstly for the reason you said: vaccine dispensing is unlikely to be extended beyond Tonga/Kiribati, and secondly because even if they were to continue, they're mostly only using mobile. (Plus we have no funding for it 😄)

kat-ms commented 2 years ago

Thanks @DhanyaHerath! That's fair, sounds like we can close this - it'll be here in the mobile issue history in case it does come up in the future or in any discussions :).