msupply-foundation / mobile

Open source mobile app for medical inventory control
http://msupply.org.nz/mobile
Other
42 stars 27 forks source link

case sensitive should not be checked during creating name #5237

Closed arjunSussol closed 1 year ago

arjunSussol commented 1 year ago

Describe the bug

Patient duplicity alert is not generated if the duplicate name created with the different case. For e.g. Arjun is not equal to arjun and duplicate name confirmation alert failed.

To reproduce

https://github.com/openmsupply/mobile/assets/13060254/cbcba9d3-6d32-4552-b1d0-a1e33351c573

Steps to reproduce the behaviour:

  1. Go to Vaccination
  2. Look for an existing name
  3. Try create duplicate name as above but with different case
  4. No duplicity check alert generated

Expected behaviour

Arjun = arjun in the case of username/name, but not valid for password. Duplicity check should be performed without caring about the case of the firstName and lastName

Proposed Solution

Leave if you don't know how to fix/implement. Edit this issue description and explain here if you know the best path of implementing the fix within the codebase.

Version and device info

Additional context

Add any other context about the problem here.

arjunSussol commented 1 year ago

Duplicate patient check not case insensitive

AnushaUp commented 1 year ago

Testing

Tested inv8.6.6-rc02 Steps to reproduce or otherwise test the changes of this PR:

AnushaUp commented 1 year ago

@arjunSussol Tested and passed👍