msupply-foundation / mobile

Open source mobile app for medical inventory control
http://msupply.org.nz/mobile
Other
42 stars 27 forks source link

finalised_date is blank when finalising Customer Invoice #5534

Open kahn-msupply opened 2 weeks ago

kahn-msupply commented 2 weeks ago

Describe the bug

CERB: https://cerb.msupply.org/profiles/ticket/JZ-2237-HT/conversation

When finalising a customer invoice on mobile, mSupply does not record a finalised_date. When finalising a customer invoice from mSupply desktop, the finalised_date field is populated with the date the customer invoice is finalised.

This affects some dashboards that use the finalised_date field for mobile records.

The supplier is using tablets to process/finalize Customer Requisitions. This is not a problem for suppliers that are on mSupply desktop as customer requisitions are converted to customer invoices first before being finalized. For tablets, the customer requisition is directly finalized once data is filled in.

For dashboard reporting, In-transit flag looks at the date when customer invoices are finalized.

mSupply Desktop (Supplier) CI:

Desktop Site

mSupply Mobile (Supplier) CI:

Taveuni_HC (Mobile)

To reproduce

Steps to reproduce the behaviour:

  1. Any datafile
  2. Setup sync site for mobile
  3. Create and finalise a customer invoice from mobile to any store
  4. Open record browser from central and find new Customer Invoice
  5. See finalised_date is 0000-00-00T00:00:00 for the finalised customer invoice

Expected behaviour

finalised_date should be the date the invoice was finalised from mSupply Mobile.

Proposed Solution

~

Version and device info

Additional context

This could possibly be fixed from mSupply central for incoming records.

kahn-msupply commented 2 weeks ago

@JonnaQuismundo asked for this issue to be moved to desktop:

https://github.com/msupply-foundation/msupply/issues/14857